From d2a82228a35ab9a241b19019c3437f9d45ec4ddb Mon Sep 17 00:00:00 2001 From: gojomo Date: Tue, 28 Jul 2009 22:56:54 +0000 Subject: [PATCH] TODO/FIXME comments where things don't seem quite right but aren't definitively buggy * CachedBdbMap.java reevaluate if clear() should include close() * CrawlURI.java investigate possible confusion in meaning of isPrerequisite() --- commons/src/main/java/org/archive/util/CachedBdbMap.java | 1 + .../src/main/java/org/archive/crawler/datamodel/CrawlURI.java | 3 +++ 2 files changed, 4 insertions(+) diff --git a/commons/src/main/java/org/archive/util/CachedBdbMap.java b/commons/src/main/java/org/archive/util/CachedBdbMap.java index 2597be9c..0e072e9d 100644 --- a/commons/src/main/java/org/archive/util/CachedBdbMap.java +++ b/commons/src/main/java/org/archive/util/CachedBdbMap.java @@ -1116,6 +1116,7 @@ implements ConcurrentMap, Serializable { this.memMap.clear(); this.diskMap.clear(); this.diskMapSize.set(0); + //TODO:FIXME: clear should not equal close! try { close(); } catch (DatabaseException e) { diff --git a/engine/src/main/java/org/archive/crawler/datamodel/CrawlURI.java b/engine/src/main/java/org/archive/crawler/datamodel/CrawlURI.java index c24fa52b..327cfcb1 100644 --- a/engine/src/main/java/org/archive/crawler/datamodel/CrawlURI.java +++ b/engine/src/main/java/org/archive/crawler/datamodel/CrawlURI.java @@ -564,6 +564,9 @@ implements ProcessorURI, MultiReporter, Serializable, OverlayContext { /** * Returns true if this CrawlURI is a prerequisite. * + * TODO:FIXME: code elsewhere is confused whether this means + * that this CrawlURI is a prerquisite for another, or *has* a + * prequisite; clean up and rename as necessary. * @return true if this CrawlURI is a prerequisite. */ public boolean isPrerequisite() {