From d4c5bd6e987e72197e0c327e90ef8a25359cf64d Mon Sep 17 00:00:00 2001
From: Noah Levitt <nlevitt@archive.org>
Date: Tue, 14 May 2013 18:17:09 -0700
Subject: [PATCH] avoid npe by setting default <input> type "text" when
 unspecified

---
 .../src/main/java/org/archive/modules/forms/HTMLForm.java  | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/modules/src/main/java/org/archive/modules/forms/HTMLForm.java b/modules/src/main/java/org/archive/modules/forms/HTMLForm.java
index 56691602..f2719e22 100644
--- a/modules/src/main/java/org/archive/modules/forms/HTMLForm.java
+++ b/modules/src/main/java/org/archive/modules/forms/HTMLForm.java
@@ -58,11 +58,14 @@ public class HTMLForm {
     public void addField(String type, String name, String value) {
         FormInput input = new FormInput();
         input.type = type;
+        // default input type is text per html standard
+        if (input.type == null) {
+            input.type = "text";
+        }
         input.name = name;
         input.value = value; 
         allInputs.add(input);
-        // default input type is text per html standard
-        if(type == null || "text".equalsIgnoreCase(type) || "email".equalsIgnoreCase(type)) {
+        if("text".equalsIgnoreCase(input.type) || "email".equalsIgnoreCase(input.type)) {
             candidateUsernameInputs.add(input);
         } else if ("password".equalsIgnoreCase(type)) {
             candidatePasswordInputs.add(input);