From e9622784f6ce9b6c48d1d64d57988fa5efabc1a4 Mon Sep 17 00:00:00 2001
From: gojomo <gojomo@daa5b2f2-a927-0410-8b2d-f5f262fa301a>
Date: Thu, 14 May 2009 20:32:42 +0000
Subject: [PATCH] Apply to h3 Fix for [HER-1225] HtmlFormCredential.java may
 create non-wellformed URLs * HtmlFormCredential.java     only insert '&' if
 previous query-string was non-empty

---
 .../archive/modules/credential/HtmlFormCredential.java    | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/modules/src/main/java/org/archive/modules/credential/HtmlFormCredential.java b/modules/src/main/java/org/archive/modules/credential/HtmlFormCredential.java
index 13b9183a..d8197149 100644
--- a/modules/src/main/java/org/archive/modules/credential/HtmlFormCredential.java
+++ b/modules/src/main/java/org/archive/modules/credential/HtmlFormCredential.java
@@ -31,6 +31,7 @@ import org.apache.commons.httpclient.NameValuePair;
 import org.apache.commons.httpclient.URIException;
 import org.apache.commons.httpclient.methods.GetMethod;
 import org.apache.commons.httpclient.methods.PostMethod;
+import org.apache.commons.lang.StringUtils;
 import org.archive.modules.ProcessorURI;
 import org.archive.net.UURI;
 import org.archive.net.UURIFactory;
@@ -167,8 +168,11 @@ public class HtmlFormCredential extends Credential {
             String currentQuery = hmb.getQueryString();
             hmb.setQueryString(data);
             String newQuery = hmb.getQueryString();
-            hmb.setQueryString(((currentQuery != null)? currentQuery: "") +
-            		"&" + newQuery);
+            hmb.setQueryString(
+                ((StringUtils.isNotEmpty(currentQuery))
+                        ? currentQuery + "&"
+                        : "")
+                + newQuery);
             result = true;
         } else {
             logger.severe("Unknown method type: " + method);