Commit Graph
211 Commits
Author SHA1 Message Date
gojomo e10a14df54 HER-1753 offer means of setting login/password that doesn't leak to process info (as when literally specified to '-a' option)
* Heritrix.java
    allow [username:]password to come from file, supplied to '-a' with '@' prefix
    also, clean up options names/help text to match current behavior
    also, offer warning about particularly weak (<8 characters, all letters, all numbers) passwords
2010-04-27 01:36:38 +00:00
gojomo b639873dae Fix broken test
* Engine.java
    tolerate (with return-false-forfailure rather than NPE) non-job directories
* EngineTest.java
    use empty temp job directory rather than (possibly full-of-junk) general junit-tests directory
2010-04-27 00:44:36 +00:00
szznax 57c857d5c6 Refinement of fixes for HER-1688 remember external job directories
* EngineResource.java
    avoid calling findJobConfigs() on each page load
2010-04-26 23:33:40 +00:00
gojomo 5034c7d96e correct spaces-for-tabs 2010-04-26 22:28:43 +00:00
gojomo c4946d04d0 HER-1688 remember external job directories
* EngineResource.java, Engine.java
    refactor for less branching/redundancy
2010-04-26 22:22:09 +00:00
gojomo 67bf73026f remove obsolete/moved example properties 2010-04-23 04:05:31 +00:00
gojomo cb5ec19b6c HER-1765 quiet excessive INFO level logging
* GenericReplayCharSequence.java
* Scoper.java
* FetchFTP.java
* FetchHTTP.java
    demote a bunch of INFO logging to FINE so that be default, console isn't filled with output for every URI handled by a busy crawl
2010-04-23 00:44:25 +00:00
gojomo 3f0059c8a8 * BeanBrowseResource.java
remove extraneous close() that seemed to be causing (harmless but distracting) console error stacks after web hits
2010-04-23 00:41:25 +00:00
gojomo 9fd648f3ef HER-1467 Allow periodic checkpointing and checkpoint-copy-logs to be set/unset during crawl
* CheckpointService.java
    reorganize so that checkpoint timedTask is reset whenever interval is reset on a running crawl
* CheckpointSuccessEvent.java, CrawlJob.java
    report successes as new kind of ApplicationEvent; propagagte to job log
* BdbModule.java
    remove obsolete unconsulted checkpointCopyLogs setting
2010-04-23 00:15:44 +00:00
gojomo ca32d0d448 HER-1692 Cannot create profile with same name as job
* JobResource.java
    if destination of copy-job fails, show flash error
2010-04-22 01:59:41 +00:00
gojomo f018a2e6f1 * StatisticsTracker.java
correct outdated comment
2010-04-13 22:47:19 +00:00
gojomo a82838cd27 HER-1756 improved crawl status reporting: more definitive start-after-setup, conclusion-after-logging of crawling
* AbstractFrontier.java
    call new finalTasks just before announcing FINISH state
* WorkQueueFrontier.java
    eliminate closeQueue
* BdbFrontier.java
    move dumpAllPendingToLog from closeQueue (triggered by CrawlController FINISHED) to finalTasks (before Frontier FINISH)
    replace closeQueue with close() override
2010-04-13 02:10:56 +00:00
gojomo 8be7be2983 fix race causing intermittent test failures on MacOS
* CrawlJob.java
    synchronize methods which mutate or change behavior based on field 'ac'; previously, some self-tests were exitting/failing immediately because they were not seeing a non-null 'ac' value.
2010-04-13 00:55:09 +00:00
gojomo 647a0b3edf HER-1754 treat robots.txt non-response as 404 (optionally?)
* CrawlServer.java
    enable a specific kind of connect-lost (no response given) to be counted as 'deemed 404' on robots retries over a minimum
* FetchStatusCodes.java
    add a synthetic code: -404, S_DEEMED_NOT_FOUND
* FetchHTTP.java
    better distinguish CONNECT_FAILED and CONNECT_LOST
* DispositionProcessor.java
    treat CONNECT_LOST same as _FAILED; simplify a test
2010-04-02 03:55:12 +00:00
szznax 693f050fb7 successfully adding external job dir is ACK flash kind 2010-03-29 15:56:09 +00:00
gojomo fd5644f109 HER-1627 followup: show error rather than match faulReadSize
* PersistProcessor.java
    rename setupEnvironment to setupCopyEnvironment to make limited purpose of env clear; catch and rethrow IllegalArgumentException with hint that second-open may be cause
* PersistLoadProcessor.java 
    catch and display IllegalArgumentException same as other failure-to-open SEVERE but proceedable exceptions
* PrecedenceLoader.java
    update method names
2010-03-26 01:02:48 +00:00
szznax ed3d64d91e part of fix for HER-1736 long pause at startup reading large per-job job.log(s)
* CrawlJob.java
2010-02-16 19:03:59 +00:00
gojomo acfe95fea3 naming/branching/visibility review for HER-1736 long pause at startup reading large per-job job.log(s)
* CrawlJob.java
    added accessor, renamed a bit, unified 2 branches
* JobResource.java
    use accessor
2010-02-13 00:47:41 +00:00
szznax e1308e80f5 reverting last checkin, also testing passwordless checkin with Karmic Eclipse 3.5.1 SVNKit 1.6.7 update 2010-02-13 00:21:22 +00:00
szznax 6c13f42242 testing Karmic Eclipse 3.5.1 (w/updated SVNKit 1.6.7) 2010-02-13 00:18:10 +00:00
szznax 2d441d611e part of fix for HER-1736 long pause at startup reading large per-job job.log(s)
* CrawlJob.java
    added boolean partialJobLogScan, and print "at least X launches" when true
* JobResource.java
    print "at least X launches" when partialJobLogScan
2010-02-12 23:21:59 +00:00
szznax 18d459f6b9 part of fix for HER-1736 long pause at startup reading large per-job job.log(s)
* CrawlJob.java
    check for excessively long job log, scan near end of file for lastLaunch
    inform user OK to move big job log aside
2010-02-12 18:54:57 +00:00
szznax 4097e29d50 part of fix for HER-1736 long pause at startup reading large per-job job.log(s)
* CrawlJob.java
    return early from scanJobLog() when job log > 1GB
2010-02-09 19:45:23 +00:00
szznax a53d9ea733 per Gordon's suggestions; renamed "Engine.css" to "engine.css" and changed flashACK class background-color to palegreen 2010-01-26 20:54:16 +00:00
gojomo 1a95e530e8 Clean-up where assumption of serializability no longer appropriate 2010-01-26 01:25:47 +00:00
gojomo 248f720cab Make Recorder facility usable independent of special crawler threads
* Recorder.java
    store reusable per-thread Recorder instance in Recorder static thread-local
* ToeThread.java
    setup reusable instance into Recorder
* RecorderMarker.java
    deleted -- unnecessary
2010-01-26 01:21:59 +00:00
gojomo f35da10154 * EnhDirectoryResource.java
improve error for POST to file when EditRepresentation-wrapping (via '?format=textedit') hasn't occurred
2010-01-26 00:18:23 +00:00
gojomo 760c40c440 * EngineResource.java
use platform-specific path-separator in partial-path-prompt
2010-01-26 00:16:52 +00:00
szznax 3dff26e277 attempt to remedy Continuum build problem with SVN. "Server certificate verification failed: issuer is not trusted (https://archive-crawler.svn.sourceforge.net)" 2010-01-12 16:45:20 +00:00
szznax 5abacafd43 fix for [HER-1729] add (deprecated) style code from Engine class to Flash class
* Heritrix.java
  added CLAP protocol to access representations via classloader
* EngineApplication.java
  added staticDir resource to serve static files under "/engine/static"
  also added org.archive.crawler.restlet package to hold static files
* EngineResource.java
  added <link> to static CSS resource
* Engine.css
  style for flashACK/NACK/ADVISORY divs
2009-12-29 23:21:10 +00:00
szznax 0cb627fff8 tried to incorporate gojomo's suggestions of 2009-11-02:
* Engine.java
  removed ERROR and WARNING strings, rely on Flash class
  log jobsDir check failure as SEVERE and return early
  collapse error-handling in considerAsJobPath() and log SEVERE
  renamed considerAsJobDirectory() to addJobDirectory()
  remove catch-and-rethrow from leaveJobPathFile() when writing,
    instead log SEVERE
  renamed leaveJobPathFile() to writeJobPathFile()
  added boolean "userRequest" arg to addJobDirectory(), and moved
    call to writeJobPathFile() inside of addJobDirectory()
  changed void considerAsJobPath(File) to String getJobPathFromFile
    and removed call to addJobDirectory
  make seperate calls to addJobDirectory() in findJobConfigs()
* EngineResource.java
  restructured "create" logic for clarity
  eliminate style code, rely on Flash class
  remove limit on "addpath" input, change to "createpath"
  removed all-caps and bangs ("!") from error messages
  removed platform-specific path separators ("/")
  call Engine.addJobDirectory() with userRequest=true in when
    form action=add
2009-12-17 01:54:21 +00:00
szznax bf2eaef6e2 Part of fix for [HER-1725] on engine page, 'create new job' form gives NPE
* Engine.java
  made protected getProfileCxmlResource() for clear testability
* EngineTest.java
  added testGetProfileCxmlResource()
2009-12-11 00:47:06 +00:00
nlevitt 56d6e2ee26 Change XmlMarshaller to static util method api, and add javadocs to XmlMarshaller.
* XmlMarshaller.java
    change to static api, and add javadocs to XmlMarshaller
* *Resource.java
    use changed XmlMarshaller api
2009-12-10 07:06:17 +00:00
nlevitt 7cf44fdf4d * JobResource.java
Remove try/catch from acceptRepresentation() - comment didn't match code
    and I don't think I intended to commit it (oops).
2009-12-10 06:08:15 +00:00
nlevitt b0e140708a Rename and document methods formerly known as presentablify*()
* BeanBrowseResource.java, ScriptResource.java, EngineResource.java, 
  JobResource.java
    rename presentablify() -> makePresentableMap(), and add javadocs
* JobRelatedResource.java
    rename presentablifyNestedNames() -> addPresentableNestedNames()
    and presentablifyObject() -> makePresentableMapFor(), and add javadocs
2009-12-10 03:38:25 +00:00
szznax 0616ddfb07 part of fix for [HER-1725] create new job gives NPE
* relocated (non-dist) profile-crawler-beans.cxml
  from engine/src/main/java
  to engine/src/main/resource
2009-12-10 00:05:51 +00:00
nlevitt 9f12f5777a * ToePool.java
shortReportLineTo(): get data from shortReportMap() to avoid duplicate code
2009-12-09 03:12:48 +00:00
nlevitt df6e31697d Rename short report methods:
- singleLineReport() -> shortReportLine()
 - singleLineReportTo() -> shortReportLineTo()
 - singleLineReportData() -> shortReportMap()
2009-12-09 02:53:02 +00:00
nlevitt f8cc922cb3 [HER-1724] revive missing newline at end of crawl-report.txt 2009-12-07 22:54:03 +00:00
gojomo 7d0061884c Prevent timing NPEs on CrawlLimitEnforcer-triggered crawl end
* AbstractFrontier.java
    close recovery log in stop() (comes later, usu. from managerThread) rather than terminate() (earlier, may occur in other threads like progress-stats-snapshot thread)
2009-12-05 00:55:55 +00:00
gojomo 21d4bce819 correct typo in built-in profile templates
* org/archive/crawler/restlet/profile-crawler-beans.cxml, org/archive/crawler/migrate/migrate-template-crawler-beans.cxml
    Percentage -> Percent
2009-12-05 00:16:55 +00:00
nlevitt 4da5095212 Keep html spartan for now.
* EditRepresentation.java 
    write() remove background color and font size styling on textarea
2009-12-04 23:30:24 +00:00
nlevitt e85972848d Format, indent xml. See discussion on [HER-1603].
* XmlMarshaller.java
    (constructor) enable xml formatting/indentation
2009-12-04 23:16:35 +00:00
nlevitt 29e8b05308 Improvement to [HER-1603?focusedCommentId=22557] fix
* BaseResource.java
    getPreferredVariant(): always prefer HTML if anything in the header
    indicates it's acceptable (even "*/*" with low q-preference)
2009-12-04 23:09:24 +00:00
nlevitt c3539d3fdc Fix for [HER-1603?focusedCommentId=22557] browsers based on WebKit (Safari,
iPhone Safari, Chrome) use a screwy 'Accept' header that if taken literally
means they prefer 'application/xml' content. Thus trying to view web UI in
these browsers results in seeing the XML version, without element markup
* BaseResource.java
    override getPreferredVariant() to bump up preference level of text/html for
    any client can accept it
* EngineResource.java, JobResource.java
    inherit from BaseResource
2009-12-04 22:56:25 +00:00
gojomo 04012279fc Misc logging-cleanup/refactoring
* CrawlerJournal.java
    improve exception logging
    combine writeLine() methods to use varargs
* FrontierJournal.java
    improve exception logging
* ArchiveUtils.java
    replace ignored  count parameter with meaingful boolean one
* CrawlURI.java
    use updated ArchiveUtils method
2009-12-04 22:23:48 +00:00
nlevitt 67a25f2dce * CheckpointService.java
getAvailableCheckpointDirectories() - avoid NullPointerException when
    checkpoints dir does not exist
2009-12-04 00:52:55 +00:00
gojomo e1bbbf5a59 [HER-1704] WorkQueueFrontier.snoozedClassQueues not bounded in size, not reported in useful order
* WorkQueueFrontier.java
    add snoozedOverflow map of (wakeTime)->(DelayedWorkQueue) for snoozes over a capped size
    maintain in parallel to snoozedClassQueues DelayQueue, maintain atomic size count
    in standard report, presort snoozedClassQueues before displaying
* DelayedWorkQueue.java
    move to top-level so serialization doesn't pull out whole frontier
* BdbFrontier.java
    initialize snoozedOverflow
* BdbMultipleWorkQueues.java
    improve error message seen on problematic checkpoint-recovery
2009-12-03 19:37:27 +00:00
gojomo 950e68091c UI touchup
* EngineResource.java
    give add-job options their own header, reorder/reword for clarity
* JobResource.java
    return to always showing 'checkpoint' button, disable if necessary, so main control buttons aren't appearing/disappearing or moving
2009-12-03 18:28:21 +00:00
gojomo 757dbf3f19 Output/UI touchup
* CheckpointService.java
    list checkpoint directories in reverse-last-modified order
    disable dubugging output to System.err
2009-12-03 18:24:17 +00:00