Alex Osborne
fd514b7bf6
Merge pull request #315 from ukwa/fix-oracle-doc-link
...
Use the Wayback Machine to repair a link to Oracle docs.
2020-03-05 01:40:39 +09:00
Andrew Jackson
b4494a7ffb
Use the Wayback Machine to repair a link to Oracle docs.
2020-03-04 15:42:29 +00:00
Tim Hennekey
348b5330bc
Utilize the d parameter
...
There are uses of this class that necessitate a lower false positive
rate than the value that was hard-coded. By making use of the parameter,
as indicated in the JavaDoc, the resulting delegate should meet the
demands of the caller.
2020-03-04 09:37:31 -05:00
Alex Osborne
b45f774066
Merge pull request #300 from hennekey/fix-299
...
Use Guice instead of custom implementation
2020-01-30 19:12:05 +09:00
Alex Osborne
fd9136dbfa
Merge pull request #304 from hennekey/remove-custom-base32
...
Replace custom Base32 encoding
2020-01-30 19:07:09 +09:00
Tim Hennekey
54e05a7864
Correct encoding
...
The previous implementation appears to always have returned upper case,
was able to encode either case, and did not reutrn padding.
2020-01-28 15:12:54 -05:00
Tim Hennekey
b5f95c5e06
Replace custom Base32 encoding
...
Guava is available so a custom implementation is unnecessary.
2020-01-24 12:46:37 -05:00
Tim Hennekey
9cb9563da3
Increment the count only when the filter notes it
...
Otherwise this is a count of how many times this add method is called,
not how many times an element was noted as being actually added.
2020-01-22 17:15:24 -05:00
Tim Hennekey
080380b18a
Use Guice instead of custom implementation
...
This uses the avaialable code in Guice rather than a custom
implementation. It also provides a performance increase (as demonstrated
by the unit tests)
2020-01-15 18:13:20 -05:00
Tim Hennekey
0fa87a36e8
Add default constructor to IdentityCacheWrapper
...
Kryo is spending a lot of time during serialization handling a
NoSuchMethodException. By adding this default constructor we can skip
doing all that work.
2020-01-15 13:39:27 -05:00
Tim Hennekey
55308ba90a
Move IdentityCacheableWrapper
...
This is utilized only in tests so it belongs there
2020-01-15 13:39:27 -05:00
Tim Hennekey
0fe8463e81
Remove AtomicInteger loop counter
...
This test isn't multithreaded so I see no need for this
2020-01-15 13:39:27 -05:00
Tim Hennekey
611fa325df
Remove unused code
...
It reduces the clarity of the surrounding code
2020-01-15 13:39:27 -05:00
Tim Hennekey
bb61aa0bcb
Fix unchecked warning
2020-01-15 13:39:27 -05:00
Noah Levitt
cefad96036
Merge pull request #276 from internetarchive/jdk11-upgrade-jetty
...
JDK11 support: upgrade to Jetty 9.4.19, Restlet 2.4.0 and drop JDK 7 support
2019-08-07 10:48:51 -07:00
Alex Osborne
0782fb0481
JDK11: upgrade engine to jetty 9.4.19 and restlet 2.4.0
...
Jetty 9.4.12+ is required for TLS to work correctly under JDK11
(due to SSL handshake failures). In order to upgrade
Jetty we also need to upgrade Restlet.
There is one intentional change in behaviour to simplify
upgrading. We remove a workaround for an old [webkit bug]
where the browser claimed to prefer application/xml. The
bug was fixed in 2011.
[webkit bug]: https://bugs.webkit.org/show_bug.cgi?id=27267
Summary of Jetty API changes:
- package names changed such as org.mortbay -> org.eclipse
- SocketConnector and SslSocketConnector merged to ServerConnector
- HashUserRealm split into UserStore and HashLoginService
- SecurityHandler -> ConstraintSecurityHandler
Summary of Restlet API changes:
- some classes have moved package (Request, Response, Router etc)
- ServerResource replaces Resource
- represent(), acceptRepresentation() renamed to get(), post()
- constructors were replaced by an init() method
- setModifiable() was removed
- getRequest().getEntityAsForm() -> new Form(entity)
- Guard -> ChallengeAuthenticator
Fixes #275
2019-08-06 15:16:37 +09:00
Alex Osborne
a5c2b46208
JDK11 support: remove unused class ObjectIdentityBdbCache and tests
...
In 2011 ObjectIdentityBdbCache was replaced by
ObjectIdentityBdbManualCache in order to "remove dependence on
GC/finalization/PhantomReference magic". It hasn't been used since.
As of JDK11 the ObjectIdentityBdbCache unit tests are failing so let's
remove it.
2019-08-02 17:10:13 +09:00
Noah Levitt
1bd8b713c6
quiet org.mortbay.log (jetty?) logging
...
There is already a clause for this in logging.properties, but it's using
log4j. It was dumping stack traces every time the client was dubious of
heritrix's self-signed certificate.
Why do we have so many identical log4j.xml's? 🤷♂️
2019-04-30 16:17:35 -07:00
Edward Betts
aa705bef2e
Correct spelling mistakes.
2018-11-04 19:49:37 +09:00
Andrew Jackson
d85d2a3fe8
Move OneLineSimpleLayout into commons so all can use it.
2017-10-12 22:10:58 +01:00
Noah Levitt
3892c17b56
ughhh appease java 8 javadoc rules
2017-06-15 17:29:22 -07:00
Mohamed Elsayed
d13bfb6a37
Remove unit tests which moved over from Heritrix3 to webarchive-commons
2017-03-09 10:26:32 -08:00
Noah Levitt
36ea1a9fb2
try to fix remaining serialization tests in oraclejdk8 by using ConcurrentSkipListMap instead of ConcurrentHashMap
2016-06-07 17:55:45 -05:00
Noah Levitt
99d87e8f23
hopefully fix serialization tests in oraclejdk8 by using TreeSet instead of HashSet in KeyedProperties.java
2016-06-07 14:53:11 -05:00
Noah Levitt
cbb5e3ab99
Simplify logic for urls with spaces, and make it better follow the pattern of UriUtils.isVeryLikelyUri(). Involves a subtle adjustment to the regex LIKELY_RELATIVE_URI_PATTERN to ensure the 2nd capturing group always gets the file extension. Also add a couple of tests of strings with spaces and file extensions that are not known good extensions.
2016-02-09 15:02:11 -08:00
Hunter Stern
088189ee8b
Fix up code based on pull requests comments. Add test for urls with spaces in them.
2016-01-28 15:11:49 -08:00
Hunter Stern
4518bc2da8
Make sure no urls with whitespace and not having good extension slip through
2016-01-20 14:29:42 -08:00
Hunter Stern
12a88d6d23
Allow spaces in urls extracted from JS.
2016-01-20 10:44:20 -08:00
Hunter Stern
23885557bb
Allow spaces in JavaScript urls, but only if they have a known good file extension
2016-01-19 18:07:05 -08:00
Noah Levitt
b7afc627ed
fix typo
2015-09-24 15:31:12 -07:00
Noah Levitt
9aabcb3272
add license header to new class
2015-09-23 12:07:38 -07:00
Noah Levitt
12dde2b693
load keytool utility main class dynamically, trying both the old and new (java 8) class names
2015-09-23 12:06:11 -07:00
Noah Levitt
1027f854ec
for ARI-4267 accept possible uris with two dots in the filename part if they end with a known good extension (e.g. "foo.min.js")
2015-04-20 17:08:47 -07:00
Noah Levitt
8009275075
make sure log4j is configured when running unit tests, to avoid log4j error messages polluting captured output and causing tests to fail, like so: https://builds.archive.org/job/Heritrix-3/org.archive.heritrix$heritrix-commons/587/testReport/org.archive.io.arc/ARCWriterTest/testLengthTooLongCompressed/
2015-02-23 11:36:29 -08:00
Noah Levitt
2078a9f0e2
remove TmpDirTestCase.java (moving to webarchive-commons)
2015-01-06 16:08:18 -08:00
Noah Levitt
64e3b1b02a
remove RecordingOutputStreamTest.java (moving to webarchive-commons)
2015-01-06 16:01:16 -08:00
Noah Levitt
78e6b8b6ab
replace accidental U+2212 MINUS SIGN with normal ascii 0x2d '-' to avoid compilation error "unmappable character for encoding ASCII"
2014-10-01 21:31:14 -07:00
Noah Levitt
a37a8de4a2
improved implementation not using TreeSet, and some initial work on integration testing of cookie handling
2014-09-28 11:59:14 -07:00
Kenji Nagahashi
29379c7e19
Merge pull request #84 from nlevitt/iipc-webarchive-commons
...
switch to mainline iipc webarchive-commons latest release (1.1.4)
2014-09-11 17:19:08 -07:00
Noah Levitt
ec0839a6fe
remove more unused classes
2014-08-29 15:23:21 -07:00
Noah Levitt
f1b0633a3d
remove unused Transform* classes
2014-08-13 10:53:03 -07:00
Noah Levitt
651d18beb1
replace use of method removed from guava library
2014-08-08 17:38:51 -07:00
Noah Levitt
339e6ec87a
for ARI-3723, accept speculative urls with query params with no value
2014-04-04 10:15:07 -07:00
Noah Levitt
cc838747af
pull methods getRecorder() and makeCrawlURI(String) into ModuleTestBase, and move ModuleTestBase into heritrix-modules so that CrawlURI is available
2014-03-31 13:38:54 -07:00
Shriphani Palakodety
c81eeced7a
added removal listener
2014-03-18 06:42:02 -04:00
Shriphani Palakodety
2f60b5f935
migration to latest guava complete
2014-03-18 06:42:02 -04:00
Shriphani Palakodety
1e8e2e2016
prevent intellij from complaining
2014-03-18 06:42:02 -04:00
Shriphani Palakodety
d0e0ee6bc6
forgot to add expireAfterWrite
2014-03-18 06:42:02 -04:00
Shriphani Palakodety
bd1047d2d2
bumped guava version to 11
2014-03-18 06:42:02 -04:00
Noah Levitt
cba663a107
fix BdbCookieStore so that cookies get replaced correctly! and test it
2014-01-20 20:02:56 -08:00