From 196e463c599027a58dae4278664cb079433d8022 Mon Sep 17 00:00:00 2001 From: KernelDeimos <7225168+KernelDeimos@users.noreply.github.com> Date: Thu, 9 Oct 2025 19:07:11 -0400 Subject: [PATCH] devex: minimal first page load logs --- src/backend/src/filesystem/hl_operations/hl_readdir.js | 2 +- src/backend/src/modules/puterfs/DatabaseFSEntryFetcher.js | 2 +- src/backend/src/modules/puterfs/lib/PuterFSProvider.js | 2 +- src/backend/src/modules/web/WebServerService.js | 7 +++---- src/backend/src/modules/web/lib/eggspress.js | 2 +- src/backend/src/routers/filesystem_api/readdir.js | 2 +- src/backend/src/services/OperationTraceService.js | 4 ++-- 7 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/backend/src/filesystem/hl_operations/hl_readdir.js b/src/backend/src/filesystem/hl_operations/hl_readdir.js index d2a6cc911..1a1ce687d 100644 --- a/src/backend/src/filesystem/hl_operations/hl_readdir.js +++ b/src/backend/src/filesystem/hl_operations/hl_readdir.js @@ -64,7 +64,7 @@ class HLReadDir extends HLFilesystemOperation { let children; - this.log.noticeme('READDIR', + this.log.debug('READDIR', { userdir: await subject.isUserDirectory(), namediff: await subject.get('name') !== user.username diff --git a/src/backend/src/modules/puterfs/DatabaseFSEntryFetcher.js b/src/backend/src/modules/puterfs/DatabaseFSEntryFetcher.js index cc9e4ced2..1de724a7b 100644 --- a/src/backend/src/modules/puterfs/DatabaseFSEntryFetcher.js +++ b/src/backend/src/modules/puterfs/DatabaseFSEntryFetcher.js @@ -192,7 +192,7 @@ module.exports = class DatabaseFSEntryFetcher extends BaseService { if ( result[0] ) return result[0]; - this.log.info(`findByPath (not cached): ${path}`) + this.log.debug(`findByPath (not cached): ${path}`) const loop = async () => { for ( let i=0 ; i < parts.length ; i++ ) { diff --git a/src/backend/src/modules/puterfs/lib/PuterFSProvider.js b/src/backend/src/modules/puterfs/lib/PuterFSProvider.js index 16c376c81..ea69da69e 100644 --- a/src/backend/src/modules/puterfs/lib/PuterFSProvider.js +++ b/src/backend/src/modules/puterfs/lib/PuterFSProvider.js @@ -185,7 +185,7 @@ class PuterFSProvider extends putility.AdvancedBase { } if ( ! entry ) { - controls.log.info(`entry not found: ${selector.describe(true)}`); + controls.log.warn(`entry not found: ${selector.describe(true)}`); } if ( entry === null || typeof entry !== 'object' ) { diff --git a/src/backend/src/modules/web/WebServerService.js b/src/backend/src/modules/web/WebServerService.js index 4f8290876..b0ce2ff7b 100644 --- a/src/backend/src/modules/web/WebServerService.js +++ b/src/backend/src/modules/web/WebServerService.js @@ -390,12 +390,11 @@ class WebServerService extends BaseService { fields.status, fields.responseTime, ].join(' '); - const log = this.services.get('log-service').create('morgan', { - concern: 'web' - }); + const log = this.services.get('log-service').create('morgan'); try { this.context.arun(() => { - log.info(message, fields); + log.info(message); + log.debug(message, fields); }); } catch (e) { console.log('failed to log this message properly:', message, fields); diff --git a/src/backend/src/modules/web/lib/eggspress.js b/src/backend/src/modules/web/lib/eggspress.js index 04d51ba60..49ae0571e 100644 --- a/src/backend/src/modules/web/lib/eggspress.js +++ b/src/backend/src/modules/web/lib/eggspress.js @@ -187,7 +187,7 @@ module.exports = function eggspress (route, settings, handler) { return next(); } } - if ( config.env === 'dev' ) { + if ( config.env === 'dev' && process.env.DEBUG ) { console.log(`request url: ${req.url}, body: ${JSON.stringify(req.body)}`); } try { diff --git a/src/backend/src/routers/filesystem_api/readdir.js b/src/backend/src/routers/filesystem_api/readdir.js index bbfda4b87..7692d0510 100644 --- a/src/backend/src/routers/filesystem_api/readdir.js +++ b/src/backend/src/routers/filesystem_api/readdir.js @@ -49,7 +49,7 @@ module.exports = eggspress('/readdir', { log = x.get('services').get('log-service').create('readdir', { concern: 'filesystem', }); - log.info(`readdir: ${req.body.subject || req.body.path || req.body.uid}`); + log.debug(`readdir: ${req.body.subject || req.body.path || req.body.uid}`); } const subject = req.values.subject; diff --git a/src/backend/src/services/OperationTraceService.js b/src/backend/src/services/OperationTraceService.js index 16d789e87..7d772492c 100644 --- a/src/backend/src/services/OperationTraceService.js +++ b/src/backend/src/services/OperationTraceService.js @@ -62,7 +62,7 @@ class OperationFrame { this.status_ = status; this._calc_effective_status(); - this.log.info( + this.log.debug( `FRAME STATUS ${status.label} ` + (status !== this.effective_status_ ? `(effective: ${this.effective_status_.label}) ` @@ -275,7 +275,7 @@ class OperationTraceService { x }); parent && parent.push_child(frame); - this.log.info(`FRAME START ` + frame.describe()); + this.log.debug(`FRAME START ` + frame.describe()); if ( ! parent ) { // NOTE: only uncomment in local testing for now; // this will cause a memory leak until frame