From 298f1cdb42e94c3905b5e7ffe4a4f552cf9cb3de Mon Sep 17 00:00:00 2001
From: KernelDeimos <7225168+KernelDeimos@users.noreply.github.com>
Date: Wed, 18 Feb 2026 13:15:47 -0500
Subject: [PATCH] fix: incorrect accessor reference in OIDCService

During development a property named `success` was inverted to a property
named `failed` which resulted in an incorrect accessor reference with a
referring piece of code that wasn't updated. This is type error.
---
 src/backend/src/services/auth/OIDCService.js | 2 +-
 src/backend/src/util/outcomeutil.js          | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/backend/src/services/auth/OIDCService.js b/src/backend/src/services/auth/OIDCService.js
index 2a4daff03..e72c9506d 100644
--- a/src/backend/src/services/auth/OIDCService.js
+++ b/src/backend/src/services/auth/OIDCService.js
@@ -234,7 +234,7 @@ export class OIDCService extends BaseService {
             assume_email_ownership: true,
         });
         const { user_id } = outcome.infoObject;
-        if ( outcome.success ) {
+        if ( outcome.succeeded ) {
             await this.linkProviderToUser(user_id, providerId, claims.sub, null);
         }
         return outcome;
diff --git a/src/backend/src/util/outcomeutil.js b/src/backend/src/util/outcomeutil.js
index df64a6ccc..2aff7b1f7 100644
--- a/src/backend/src/util/outcomeutil.js
+++ b/src/backend/src/util/outcomeutil.js
@@ -7,6 +7,9 @@ export class OutcomeObject {
     fields = {};
     ended = false;
     infoObject;
+    get succeeded () {
+        return this.ended && !this.failed;
+    }
     constructor (infoObject) {
         this.failed = true;
         this.userMessageFields = {};