From ec766eecc228b65b7a9d4bc824a662dd0d3337a1 Mon Sep 17 00:00:00 2001 From: Daniel Salazar Date: Wed, 25 Mar 2026 15:05:43 -0700 Subject: [PATCH] fix: syntax issue with sql (#2730) --- extensions/extensionController/src/ExtensionController.ts | 2 +- .../src/controllers/InstalledAppsController.ts | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/extensions/extensionController/src/ExtensionController.ts b/extensions/extensionController/src/ExtensionController.ts index a1317c0e8..994fbe4fb 100644 --- a/extensions/extensionController/src/ExtensionController.ts +++ b/extensions/extensionController/src/ExtensionController.ts @@ -151,7 +151,7 @@ export class ExtensionController { ); } } - await route.handler.bind(this)(req, res, next); + return await route.handler.bind(this)(req, res, next); } catch ( error ) { if ( error instanceof HttpError ) { res.status(error.statusCode).send({ error: error.message }); diff --git a/extensions/installedApps/src/controllers/InstalledAppsController.ts b/extensions/installedApps/src/controllers/InstalledAppsController.ts index 816196550..48573eca7 100644 --- a/extensions/installedApps/src/controllers/InstalledAppsController.ts +++ b/extensions/installedApps/src/controllers/InstalledAppsController.ts @@ -27,7 +27,7 @@ export class InstalledAppsController extends ExtensionController { async getInstalledApps (req: Request, res: Response): Promise { const actor = req.actor; if ( ! actor ) { - throw Error('actor not found in context'); + throw new HttpError(401, 'actor not found in context'); } if ( actor.type.app ) { throw new HttpError(403, 'Apps are not allowed to access this resource'); @@ -49,7 +49,7 @@ export class InstalledAppsController extends ExtensionController { apps.uid, apps.title, apps.description, - MIN(perm.dt) AS installed_at, + MIN(perm.dt) AS installed_at FROM apps LEFT JOIN user_to_app_permissions AS perm ON apps.id = perm.app_id WHERE perm.user_id = ? @@ -57,7 +57,7 @@ export class InstalledAppsController extends ExtensionController { ORDER BY ${orderByField} ${sortDirection} LIMIT ? OFFSET ?`, - [actor.type.user.id, actor.type.user.id, limit, offset], + [actor.type.user.id, limit, offset], ) as { name: string; uid: string;