From ece8ad5f1d5731c82087272be5706bda17a93c81 Mon Sep 17 00:00:00 2001 From: Juan Castro Date: Wed, 7 Oct 2026 09:45:26 -0400 Subject: [PATCH] fix: register the Apple-domain backfill with the sqlite runner MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The sqlite migration list is hand-maintained, so the file alone did nothing — a fresh boot still reported 87 files and stopped at version 86. MySQL and Postgres read their directories, so only this one needed the entry. Caught by booting a local instance rather than by the suite: the client tests pin `CURRENT_SCHEMA_VERSION`, which fails once the entry exists but says nothing while the file is simply unregistered. Verified against a seeded database at the old version. `John.Smith@iCloud.com` went from `johnsmith@icloud.com` to `john.smith@icloud.com`, `a.b+tag@me.com` from `ab@me.com` to `a.b@me.com` — subaddressing still folded — and a gmail row was left alone. --- src/backend/clients/database/SqliteDatabaseClient.test.ts | 2 +- src/backend/clients/database/SqliteDatabaseClient.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/backend/clients/database/SqliteDatabaseClient.test.ts b/src/backend/clients/database/SqliteDatabaseClient.test.ts index 95493c67c..ce35921d0 100644 --- a/src/backend/clients/database/SqliteDatabaseClient.test.ts +++ b/src/backend/clients/database/SqliteDatabaseClient.test.ts @@ -27,7 +27,7 @@ import { DatabaseClientFactory } from './index.js'; import { SqliteDatabaseClient } from './SqliteDatabaseClient.js'; /** Highest schema version the migration table can reach. */ -const CURRENT_SCHEMA_VERSION = 86; +const CURRENT_SCHEMA_VERSION = 87; /** * These suites migrate real files on disk. Idle they finish in well under a diff --git a/src/backend/clients/database/SqliteDatabaseClient.ts b/src/backend/clients/database/SqliteDatabaseClient.ts index 7cd22b5ba..4bae677d3 100644 --- a/src/backend/clients/database/SqliteDatabaseClient.ts +++ b/src/backend/clients/database/SqliteDatabaseClient.ts @@ -120,6 +120,7 @@ const AVAILABLE_MIGRATIONS: [number, string[]][] = [ [83, ['0088_apps-index-url.sql']], [84, ['0089_team-require-2fa.sql']], [85, ['0090_user-app-permission-index.sql']], + [86, ['0091_icloud-dot-significance.sql']], ]; export class SqliteDatabaseClient extends AbstractDatabaseClient {