From fe1d78d5bf4a49daca2156d4b56bca719bd9cd40 Mon Sep 17 00:00:00 2001 From: KernelDeimos <7225168+KernelDeimos@users.noreply.github.com> Date: Wed, 24 Sep 2025 16:47:50 -0400 Subject: [PATCH] conf(eslint): fix backend rule, -@stylistic/quotes This commit fixes the block that's meant to match backend files. There was an error in the arguments for '@stylistic/indent' which was effectively disabling the entire block. In vscode, it is very unclear that this is happening, so I had to manually run this command: npx eslint "src/backend/**/*.js" --debug This commit also disables @stylistic/quotes; I disagree with this rule for several reasons: 1. Sometimes the appropriate quote depends on the contents: i.e. '""""' + "''''" is cleaner than '""""\'\'\'\''. 2. If you argue that mixing quotes between concatenated strings (like the previous example) is a bad idea, then I can further state that this rule forces me to mix quotes: `we use a ${templateString}` + "but can't do it here" --- eslint.config.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/eslint.config.js b/eslint.config.js index 60aab2c03..e7da01b95 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -32,12 +32,14 @@ export default defineConfig([ '@stylistic/curly-newline': ['error', 'always'], '@stylistic/object-curly-spacing': ['error', 'always'], '@stylistic/indent': ['error', 4, { - 'CallExpression': 4, + CallExpression: { + arguments: 4, + }, }], '@stylistic/indent-binary-ops': ['error', 4], '@stylistic/array-bracket-newline': ['error', 'consistent'], '@stylistic/semi': ['error', 'always'], - '@stylistic/quotes': ['error', 'single'], + '@stylistic/quotes': 'off', '@stylistic/function-call-argument-newline': ['error', 'consistent'], '@stylistic/arrow-spacing': ['error', { before: true, after: true }], '@stylistic/space-before-function-paren': ['error', { 'anonymous': 'never', 'named': 'never', 'asyncArrow': 'always', 'catch': 'never' }], @@ -62,6 +64,7 @@ export default defineConfig([ }, { files: ['**/*.{js,mjs,cjs}'], + ignores: ['src/backend/**/*.{js,mjs,cjs}'], languageOptions: { globals: globals.browser }, rules: {