From 52e9af73b1c87eaa83bc18cb91cada6ee2cdf91a Mon Sep 17 00:00:00 2001 From: N0zoM1z0 <161784452+N0zoM1z0@users.noreply.github.com> Date: Tue, 13 Oct 2026 14:24:48 +0800 Subject: [PATCH] fix(ci): run Windows regressions for matcher source edits Register the path-grammar owner in package scope and verify source-only edits select both Windows and JavaScript recovery lanes. Addresses the #2635 review finding; 85 scope checks and two curated-path checks pass. Runtime code remains identical to the real-data verified version. --- .../analysis-efficiency/windows-posix-reconciliation.md | 6 ++++++ scripts/ci/scopes.mjs | 1 + tests/boundary/filesystem/ciChangeScope.test.ts | 4 ++++ 3 files changed, 11 insertions(+) diff --git a/experiments/analysis-efficiency/windows-posix-reconciliation.md b/experiments/analysis-efficiency/windows-posix-reconciliation.md index 56a547d38a..3a78b1d7cd 100644 --- a/experiments/analysis-efficiency/windows-posix-reconciliation.md +++ b/experiments/analysis-efficiency/windows-posix-reconciliation.md @@ -102,3 +102,9 @@ The full format gate at that main revision failed on the unchanged upstream GhidraDoctor.test.ts and GhidraSnapshotCache.test.ts files. The PR does not repair those unrelated baseline files. Resource figures above refer to the earlier candidate; the integration replay does not establish a speedup. + +Review found that owning only the Windows test path would still skip that lane +on a later implementation-only edit. The matcher implementation is now also +registered in package scope. A source-only classifier case verifies that it +selects both Windows package and JavaScript recovery lanes; 85 scope checks and +two curated-path checks pass. Runtime code and the real-data checks are unchanged. diff --git a/scripts/ci/scopes.mjs b/scripts/ci/scopes.mjs index 4ad8f7d742..ffe15cb3d7 100644 --- a/scripts/ci/scopes.mjs +++ b/scripts/ci/scopes.mjs @@ -57,6 +57,7 @@ export const SCOPES = { "tests/boundary/filesystem/windowsNpxRegistration.test.ts", "tests/acceptance/setup/homeDirectoryFallback.test.ts", "tests/boundary/filesystem/javascriptApplicationWorkflows.test.ts", + "src/domain/javascript/javascriptRuntimeStaticCandidates.ts", "tests/boundary/filesystem/webScriptManifestPaths.test.ts", "tests/boundary/process/ProcessEvidence.host.test.ts", "tests/acceptance/webModuleCli.test.ts", diff --git a/tests/boundary/filesystem/ciChangeScope.test.ts b/tests/boundary/filesystem/ciChangeScope.test.ts index 163219c39d..321160a364 100644 --- a/tests/boundary/filesystem/ciChangeScope.test.ts +++ b/tests/boundary/filesystem/ciChangeScope.test.ts @@ -515,6 +515,10 @@ it.each([ "src/windows/Example.ts", { code: true, runtime: true, package: true, apple: false, evm: false }, ], + [ + "src/domain/javascript/javascriptRuntimeStaticCandidates.ts", + { code: true, runtime: true, package: true, javascript_recovery: true }, + ], ["install.sh", { code: true, runtime: true, package: true, evm: false }], [ ".agents/skills/reverse-engineer-anything/SKILL.md",