refactor: remove cross-version investigation workflow

scripts/lib/catalog-core.mjs

@@ -64,7 +64,6 @@ const SOURCE_PATHS = {
   processCapture: "dist/domain/processCapture.js",
   analysisSnapshot: "dist/domain/analysisSnapshot.js",
   artifactGraph: "dist/domain/artifactGraph.js",
-  investigationWorkspace: "dist/domain/investigationWorkspace.js",
   browserObservation: "dist/domain/browserObservation.js",
   browserScenario: "dist/domain/browserScenario.js",
   browserScenarioCapture: "dist/domain/browserScenarioCapture.js",

scripts/verify-package-investigation.mjs

@@ -1,72 +0,0 @@
-import { execFile } from "node:child_process";
-import { readFile, rm, writeFile } from "node:fs/promises";
-import { join } from "node:path";
-import { promisify } from "node:util";
-
-import { TextReader, Uint8ArrayWriter, ZipWriter } from "@zip.js/zip.js";
-
-const exec = promisify(execFile);
-
-/** Verify the packed CLI's persistent investigation and idempotent reuse. */
-export async function verifyPackagedInvestigation(input) {
-  const artifactArchiveV2 = join(input.workspace, "artifact-v2.zip");
-  const writer = new ZipWriter(new Uint8ArrayWriter());
-  await writer.add("app/main.js", new TextReader("main(2);"));
-  await writer.add("app/new.js", new TextReader("feature();"));
-  await writeFile(artifactArchiveV2, await writer.close());
-  const workspacePath = join(input.evidenceRoot, "versions.json");
-  const args = [
-    "investigate-versions",
-    input.artifactArchive,
-    artifactArchiveV2,
-    workspacePath,
-    "--workspace-name",
-    "package-versions",
-    "--yes",
-    "--json",
-  ];
-  const investigated = await runJson(input.cli, args, input.environment);
-  const reused = await runJson(input.cli, args, input.environment);
-  let persisted = JSON.parse(await readFile(workspacePath, "utf8"));
-  const runId = investigated.normalized_result?.investigation_run?.run_id;
-  if (runId === undefined)
-    throw new Error("packaged investigation did not return a run ID");
-  await Promise.all([
-    rm(input.artifactArchive, { force: true }),
-    rm(artifactArchiveV2, { force: true }),
-  ]);
-  const replayed = await runJson(
-    input.cli,
-    [...args.slice(0, -1), "--replay-run-id", runId, "--json"],
-    input.environment,
-  );
-  persisted = JSON.parse(await readFile(workspacePath, "utf8"));
-  if (
-    investigated.operation !== "find_changed_behavior" ||
-    investigated.normalized_result?.behavior_status !== "unknown" ||
-    replayed.evidence_id !== investigated.evidence_id ||
-    reused.evidence_id !== investigated.evidence_id ||
-    persisted.revision !== 3 ||
-    persisted.runs?.[0]?.status !== "complete"
-  )
-    throw new Error("packaged persistent investigation CLI failed");
-  return {
-    arguments: {
-      approved: true,
-      workspace_path: workspacePath,
-      workspace_name: "package-versions",
-      expected_workspace_revision: persisted.revision,
-      replay_run_id: runId,
-      left_path: input.artifactArchive,
-      right_path: artifactArchiveV2,
-    },
-    evidenceId: investigated.evidence_id,
-    workspacePath,
-    revision: persisted.revision,
-  };
-}
-
-async function runJson(command, args, environment) {
-  const output = await exec(command, args, { env: environment });
-  return JSON.parse(output.stdout);
-}

scripts/verify-package-mcp.mjs

@@ -1,4 +1,3 @@
-import { readFile } from "node:fs/promises";
 import { join } from "node:path";
 import { execFile } from "node:child_process";
 import { promisify } from "node:util";
@@ -17,28 +16,6 @@ const verifyMcpToolsAndPrompts = async (client, mcpOptions) => {
   await prompts.verifyPromptCompletion(client, mcpOptions, false);
 };
 
-const verifyMcpReplay = async (client, mcpOptions, investigationReplay) => {
-  const replay = await client.callTool(
-    {
-      name: "find_changed_behavior",
-      arguments: { investigation_run: investigationReplay.arguments },
-    },
-    mcpOptions,
-  );
-  const replayEvidence = json(prompts.mcpText(replay));
-  const replayWorkspace = json(
-    await readFile(investigationReplay.workspacePath, "utf8"),
-  );
-  if (
-    replay.isError === true ||
-    replayEvidence.evidence_id !== investigationReplay.evidenceId ||
-    replayWorkspace.revision !== investigationReplay.revision
-  )
-    throw new Error(
-      "packaged MCP did not replay with workspace-only authority",
-    );
-};
-
 const verifyMcpTargetFree = async (client, mcpOptions) => {
   const status = await client.callTool(
     { name: "binary_session", arguments: {} },
@@ -179,12 +156,7 @@ const verifyMcpEvidenceBundle = async (client, mcpOptions, evidenceRoot) => {
 };
 
 /** Connect to the packaged MCP server and exercise the target-free catalog. */
-export async function verifyPackageMcp({
-  cli,
-  environment,
-  evidenceRoot,
-  investigationReplay,
-}) {
+export async function verifyPackageMcp({ cli, environment, evidenceRoot }) {
   const diagnosed = json(
     (
       await execute(cli, ["mcp", "doctor", "--json"], {
@@ -216,7 +188,6 @@ export async function verifyPackageMcp({
     await client.connect(transport);
     const mcpOptions = { timeout: 15_000 };
     await verifyMcpToolsAndPrompts(client, mcpOptions);
-    await verifyMcpReplay(client, mcpOptions, investigationReplay);
     await verifyMcpTargetFree(client, mcpOptions);
     await verifyMcpUnknownProvider(client, mcpOptions);
     await verifyMcpBinaryLifecycle(client, mcpOptions);

scripts/verify-package.mjs

@@ -6,7 +6,6 @@ import { TOOL_CONTRACTS } from "../dist/contracts/toolContracts.js";
 import { PRODUCT_IDENTITY } from "../dist/identity.js";
 import { MCP_STARTUP_POLICY } from "../dist/mcpStartupPolicy.js";
 import * as prompts from "./verify-package-prompts.mjs";
-import { verifyPackagedInvestigation } from "./verify-package-investigation.mjs";
 import { verifyPackageArtifactAndElectron } from "./verify-package-artifact.mjs";
 import { verifyPackageCapabilitiesAndSearch } from "./verify-package-capabilities.mjs";
 import { verifyPackageDiscovery } from "./verify-package-discovery.mjs";
@@ -70,7 +69,7 @@ try {
     cli,
     environment: environmentData.environment,
   });
-  const { artifactArchive } = await verifyPackageArtifactAndElectron({
+  await verifyPackageArtifactAndElectron({
     cli,
     workspace,
     environment: environmentData.environment,
@@ -80,13 +79,6 @@ try {
     workspace,
     environment: environmentData.environment,
   });
-  const investigationReplay = await verifyPackagedInvestigation({
-    cli,
-    workspace,
-    evidenceRoot,
-    artifactArchive,
-    environment: environmentData.environment,
-  });
   await verifyUnknownProvider({
     cli,
     environment: environmentData.environment,
@@ -123,7 +115,6 @@ try {
     cli,
     environment: environmentData.environment,
     evidenceRoot,
-    investigationReplay,
   });
   process.stdout.write(
     `${JSON.stringify({ verifier_run: await completeVerifierRun(verifierRun), cli: true, analysisCli: true, artifactCli: true, managedCli: true, managedReconstructionCli: true, managedNativeVerificationCli: true, managedRuntimePlanCli: true, managedApplicationGraphCli: true, evidenceCli: true, incurMcpCommand: PRODUCT_IDENTITY.mcpCommand, lifecycleScriptsRequired: false, doctor: "platform-appropriate", setup: supportedSetupHost ? "planned-then-idempotent" : "unsupported-host-rejected", setupPlanReadOnly: supportedSetupHost, existingHopperPreserved: supportedSetupHost, clients: supportedSetupHost ? 3 : 0, backupReadback: supportedSetupHost, failureRecovery: supportedSetupHost, configSymlinkLifecycle: supportedSetupHost, skill: supportedSetupHost, skillReferences: supportedSetupHost, mcpTools: TOOL_CONTRACTS.length, mcpPrompts: prompts.names.length, promptCompletion: true, promptCompletionLifecycle: true, evidenceMcp: true, targetFree: true, targetLifecycle: true, boundedRegexBridge: true, mcpStartup, mcpModuleLoading })}\n`,