fix(build): make catalogs and packaged skills generated outputs (#1086)

* fix(build): generate catalogs and packaged skills without snapshot commits

* fix(build): point skill drift recovery to uncached generation

.github/pull_request_template.md

@@ -28,7 +28,7 @@ intentionally not included. -->
 - Provider, bridge, target-format, or platform compatibility:
 - Evidence, artifact, provenance, or reconstruction contract:
 - Process execution, authorization, cleanup, or containment impact:
-- Generated metadata (`docs/product-catalog.json`), package, or installation impact (the regen-generated bot pushes tracked generated files; never hand-edit them):
+- Generated metadata (`docs/public/product-catalog.json`), package, or installation impact (CI generates and validates ignored catalogs and `skills/`; edit authored instructions in `skill-src/` and never commit build outputs):
 
 ## Evidence and regression coverage
 

.github/workflows/ci.yml

@@ -488,3 +488,13 @@ jobs:
           cache: npm
       - run: npm ci
       - run: npm run docs:check
+      - name: Generation leaves authored files unchanged
+        run: git diff --exit-code
+      - uses: actions/upload-artifact@v4
+        with:
+          name: generated-docs
+          path: |
+            docs/public/product-catalog.json
+            docs/verification/managed-conformance-*.json
+            skills/reverse-engineer-anything
+          if-no-files-found: error

.github/workflows/regen-generated.yml

@@ -1,75 +0,0 @@
-name: Regenerate generated metadata
-
-on:
-  pull_request:
-    branches: [main]
-    paths:
-      - "src/**"
-      - "skills/**/SKILL.md"
-      - "scripts/generate-*.mjs"
-      - "scripts/check-doc-facts.mjs"
-      - "scripts/lib/*.mjs"
-      - "scripts/verify/managed/**"
-      - "scripts/fixtures/managed/**"
-      - "package.json"
-      - "package-lock.json"
-
-concurrency:
-  group: regen-${{ github.event.pull_request.number }}
-  cancel-in-progress: true
-
-env:
-  HUSKY: "0"
-
-permissions:
-  contents: write
-
-jobs:
-  regen:
-    name: Regenerate and push tracked generated files
-    # Same-repo PRs only: the default token cannot push to forks.
-    # The bot-actor guard stops looped runs triggered by our own push.
-    if: >-
-      github.actor != 'github-actions[bot]' &&
-      github.event.pull_request.head.repo.full_name == github.repository
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event.pull_request.head.ref }}
-      - uses: actions/setup-node@v4
-        with:
-          node-version-file: .nvmrc
-          cache: npm
-      - run: npm ci
-      - run: npm run docs:generate
-      - name: Commit regenerated files
-        shell: bash
-        env:
-          HEAD_REF: ${{ github.event.pull_request.head.ref }}
-        run: |
-          generated_paths=(
-            docs/product-catalog.json
-            docs/error-contract.schema.json
-            docs/verification/managed-conformance-manifest.json
-            docs/verification/managed-conformance-ledger.json
-            skills/reverse-engineer-anything/SKILL.md
-            src/generatedPackageMetadata.ts
-          )
-          if git diff --quiet -- "${generated_paths[@]}"; then
-            echo "Generated metadata is already canonical."
-            exit 0
-          fi
-          git diff --check
-          # Refuse to sweep unrelated working-tree changes into the bot commit.
-          unexpected="$(git diff --name-only | grep -vxF -f <(printf '%s\n' "${generated_paths[@]}") || true)"
-          if [[ -n "${unexpected}" ]]; then
-            echo "docs:generate left unexpected tracked changes:" >&2
-            printf '%s\n' "${unexpected}" >&2
-            exit 1
-          fi
-          git config user.name "github-actions[bot]"
-          git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
-          git add -- "${generated_paths[@]}"
-          git commit -m "chore: regenerate generated metadata"
-          git push origin "HEAD:${HEAD_REF}"

.github/workflows/release.yml

@@ -170,43 +170,9 @@ jobs:
         if: inputs.phase == 'prepare' && steps.release.outputs.prs_created == 'true'
         run: npm run docs:generate
 
-      - name: Commit canonical release catalog
+      - name: Validate generated release documentation
         if: inputs.phase == 'prepare' && steps.release.outputs.prs_created == 'true'
-        shell: bash
-        env:
-          # Use the same identity for the follow-up commit so it also triggers CI.
-          GH_TOKEN: ${{ secrets.RELEASE_PLEASE_TOKEN || secrets.GITHUB_TOKEN }}
-          RELEASE_PR_JSON: ${{ steps.release.outputs.pr }}
-        run: |
-          release_pr_branch="$(node --input-type=module -e '
-            const value = JSON.parse(process.env.RELEASE_PR_JSON ?? "");
-            if (
-              typeof value !== "object" ||
-              value === null ||
-              typeof value.headBranchName !== "string" ||
-              value.headBranchName.length === 0
-            ) {
-              process.exit(1);
-            }
-            process.stdout.write(value.headBranchName);
-          ')"
-          changed_paths="$(git diff --name-only)"
-          if [[ -z "${changed_paths}" ]]; then
-            echo "Release documentation is already canonical."
-            exit 0
-          fi
-          if [[ "${changed_paths}" != "docs/product-catalog.json" ]]; then
-            echo "docs:generate changed unexpected tracked paths:" >&2
-            printf '%s\n' "${changed_paths}" >&2
-            exit 1
-          fi
-          git diff --check
-          git config user.name "github-actions[bot]"
-          git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
-          git add -- docs/product-catalog.json
-          git commit -m "chore: normalize release product catalog"
-          gh auth setup-git
-          git push origin "HEAD:${release_pr_branch}"
+        run: npm run docs:check && git diff --exit-code
 
   publish:
     name: Publish to npm