Kaoru0822andClaude Opus 5.5
7c9c1ebdb7
startMcpTransport loads optional observation providers once per process and passes them to every server instance the SDK constructs. Each instance's closeProviders also closed the shared browser scenario provider, so when the SDK discarded a server/discover probe instance for a legacy initialize, every later capture_browser_scenario call failed with "Browser scenario provider is closing." Server instances no longer close the caller-supplied provider; the transport returns closeOptionalProviders and process shutdown closes it once. Fixes #2195 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
62 lines
2.3 KiB
TypeScript
62 lines
2.3 KiB
TypeScript
import { STDIO_DEFAULT_MAX_BUFFER_SIZE } from "@modelcontextprotocol/server";
|
|
import { expect, it, vi } from "vitest";
|
|
|
|
import type { BrowserScenarioCapturePort } from "../../../src/application/BrowserScenarioCapturePort.js";
|
|
import { silentLogger } from "../../../src/logger.js";
|
|
import { startMcpTransport } from "../../../src/main/transport.js";
|
|
import type { RuntimeDependencies } from "../../../src/main/types.js";
|
|
import { ToolResultDelivery } from "../../../src/server/toolResult.js";
|
|
import { createTestBinarySession } from "../../fixtures/binarySession.js";
|
|
|
|
it("keeps the shared browser scenario provider open when the SDK discards its discovery probe", async () => {
|
|
const session = createTestBinarySession(() => {
|
|
throw new Error("Unexpected deep provider");
|
|
});
|
|
const close = vi.fn(async () => undefined);
|
|
const browserScenarioCapture: BrowserScenarioCapturePort = {
|
|
identity: () => ({
|
|
id: "fake-browser",
|
|
name: "Fake browser",
|
|
version: "1",
|
|
}),
|
|
captureScenario: async () => {
|
|
throw new Error("Unexpected scenario capture");
|
|
},
|
|
close,
|
|
};
|
|
const factories: Parameters<RuntimeDependencies["serve"]>[0][] = [];
|
|
const runtime: RuntimeDependencies = {
|
|
env: {},
|
|
serve: (factory) => {
|
|
factories.push(factory);
|
|
return { close: async () => undefined };
|
|
},
|
|
writeStderr: () => undefined,
|
|
setExitCode: () => undefined,
|
|
registerShutdown: () => () => undefined,
|
|
};
|
|
const transport = await startMcpTransport(runtime, session, {
|
|
logger: silentLogger,
|
|
serverLogger: silentLogger,
|
|
environment: runtime.env,
|
|
delivery: new ToolResultDelivery(STDIO_DEFAULT_MAX_BUFFER_SIZE),
|
|
loadOptionalProviders: async () => ({ browserScenarioCapture }),
|
|
});
|
|
if (!transport.ok) throw new Error("Transport failed");
|
|
const factory = factories[0];
|
|
if (factory === undefined) throw new Error("Missing SDK server factory");
|
|
try {
|
|
const probe = await factory({ era: "modern" });
|
|
await probe.close();
|
|
const replacement = await factory({ era: "legacy" });
|
|
await replacement.close();
|
|
expect(close).not.toHaveBeenCalled();
|
|
|
|
await transport.closeOptionalProviders();
|
|
expect(close).toHaveBeenCalledTimes(1);
|
|
} finally {
|
|
await transport.closeAndroid();
|
|
await session.close();
|
|
}
|
|
});
|