Files
rea/tests/composition/resolveWindowsProviderExecutable.test.ts
4aa51bfe19 fix(reverse): reconcile cleanup ownership and mutation diagnostics (#2799)
* feat(process): add owned debugger shutdown lifecycle

* feat(reverse): add local inspection commands

* feat(gdb): add persistent debugger integration

* feat(cutter): add Cutter bridge integration

* test(reverse): enforce complete integration coverage

* fix(process): preserve debugger shutdown ownership

* fix(reverse): retain evidence across interrupted commands

* fix(gdb): honor captured provider environment

* test(process): cover debugger shutdown retries

* fix(reverse): retain evidence for interrupted providers

* test(process): cover debugger shutdown retries

* fix(reverse): retain evidence for interrupted providers

* fix(server): snapshot provider environment at creation

* fix(reverse): close review gaps with complete coverage

* fix(reverse): address inspection review findings

* fix(gdb): bound sessions and retain cleanup ownership

* fix(ci): require reverse-tools quality lane

* fix(process): unref inherited debugger output pipes

* fix(reverse): address remaining PR 1960 findings

* fix(gdb): address remaining PR 1961 findings

* fix(reverse): account for unrestricted provider execution

* fix(process): retain debugger ownership until safe shutdown

* fix(process): preserve replacement debugger sessions

* fix(reverse): preserve admission and output provenance

* fix(process): retain exited debugger until output settles

* fix(mcp): bound provider admission and debugger cleanup

* fix(reverse): preserve failure provenance and classify E2BIG

* fix(gdb): preserve startup cleanup and detach safety

* fix(process): retain debugger ownership after detach failure

* fix(reverse): preserve mutation and failure provenance

* fix(gdb): address debugger review findings

* fix(reverse): rebind sessions after external mutation

* fix(process): cap debugger output after exit

* fix(gdb): protect one-shot detach verification

* feat(debugger): add reverse tool coverage gate

* test(debugger): cover integrated failure paths

* fix(gdb): bound and preserve session observations

* fix(gdb): address review regressions

* style: format merged integration files

* fix(reverse): preserve session and output evidence

* refactor(gdb): share repeated test and partial result setup

* fix(gdb): invalidate TTY proof for Python aliases

* fix(reverse): retain failure output byte counts

* test(process): synchronize late debugger output

* fix(gdb): invalidate TTY proof for wrapped commands

* fix(gdb): recognize wit command abbreviation

* test(reverse): wait for cancelled descendant readiness

* test(reverse): bound descendant cancellation cleanup

* style(reverse): format integration tests and adapters

* style: format reverse engineering integration files

* test(reverse): remove duplicate environment harness

* test(gdb): share session startup assertions

* fix(gdb): invalidate output proof for command abbreviations

* test(reverse): share composition edge case scenarios

* fix(ci): recognize verification and mutation tool entries

* test(rizin): cover successful fake inferior detach

* test(cli): align full output failure envelope

* test(cli): isolate reverse command lifecycle service

* test(process): share debugger output fixture setup

* fix(binary): preserve high-bit Windows signature bytes

* style(binary): format Windows signature parser

* test(mcp): preserve call coverage in unchanged comparison

* fix(ci): include reverse tools Vitest configs in lint cache

* fix(mcp): preserve target content on delivery errors

* ci: align duplication ceiling with expanded suite

* test(reverse): allow signal admission mutants

* fix(reverse): bound retained cleanup failures to process owners

* fix(test): replace drifting mutation ranges with owned selectors

* fix(reverse): admit persistent commands and retain cleanup ownership

* fix(cutter): recover timed-out commands from exact receipts

* fix(cutter): reject unsupported bridge request kinds

* fix(ci): repair client format and shared verification fixtures

* fix(native): preserve debugger cleanup ownership and bridge authentication

* test(native): retain diagnostics without perfect coverage requirements

* chore(licenses): refresh locked dependency inventory and notices

* fix(test): exclude transient command locks from mutation sandboxes

* fix(gdb): admit only platforms with safe detach verification

* fix(cutter): retain bounded completion receipts until acknowledgement

* fix(cutter): acknowledge commands rejected before UI dispatch

* test(reverse): fail cancellation checks before fixture teardown

* test(gdb): clean up the retained broken-stdin fixture owner

* docs(test): clarify focused provider verification scope

* fix(rizin): retain close cleanup failures

* fix(gdb): wait for inferior stop and bound MI buffering

* fix(cutter): retain failed receipt acknowledgements

* fix(rizin): return retained session identity on rebind failure

* fix(gdb): preserve startup cancellation and lossy status

* fix(rizin): retain launch provenance and assemble frames once

* fix(cutter): recover receipts across callers and bound discovery

* docs: describe debugger evidence and bridge recovery

* fix(process): keep cleanup incomplete while writers remain

Stopping a debugger no longer reports success when inherited output
streams stay open, so BinarySession cannot reopen a binary a child is
still changing. Concurrent Cutter cleanup retries share one receipt
acknowledgement instead of treating a consumed receipt as failure.

* fix(debuggers): recover cleanup with captured process identities

* fix(analysis): retire sessions after unrestricted commands

* fix(cli): preserve completed evidence after cleanup recovery

* fix(cutter): bound frame collection and coalesce cleanup

* fix(windows): resolve selected provider paths absolutely

* fix(gdb): report decoding loss in failed startup evidence

* fix(rizin): scope decoding loss to collected command frames

* test(mcp): cover snapshot retirement in reverse tools CI

---------

Co-authored-by: Daniel Gonçalves Araujo <47118053+dandgabr@users.noreply.github.com>
Co-authored-by: REA Maintainers <noreply@github.com>
Co-authored-by: OpenAI Codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-10-14 04:47:34 +08:00

96 lines
2.8 KiB
TypeScript

import { win32 } from "node:path";
import { describe, expect, it } from "vitest";
import { resolveWindowsProviderExecutable } from "../../src/composition/resolveWindowsProviderExecutable.js";
import { createReverseEngineeringCommandPort } from "../../src/composition/reverseEngineering.js";
const windowsLookup = (cwd: string, files: readonly string[]) => {
const existingFiles = new Set(
files.map((path) => win32.normalize(path).toLowerCase()),
);
return {
cwd,
isFile: (path: string): boolean =>
existingFiles.has(win32.normalize(path).toLowerCase()),
};
};
describe("resolveWindowsProviderExecutable", () => {
it("resolves a bare name from quoted and relative Windows PATH entries", () => {
const cwd = "C:\\work";
const expected = "C:\\work\\Program Files\\REA Tools\\objdump.EXE";
expect(
resolveWindowsProviderExecutable(
"objdump",
{
PATH: `.;".\\Program Files\\REA Tools";D:\\unused`,
PATHEXT: ".COM;.EXE;.BAT",
},
windowsLookup(cwd, [expected]),
),
).toBe(expected);
});
it("resolves a relative configured path against the caller's Windows CWD", () => {
expect(
resolveWindowsProviderExecutable(
".\\tools\\objdump.exe",
{},
windowsLookup("D:\\analysis", []),
),
).toBe("D:\\analysis\\tools\\objdump.exe");
});
it("resolves relative PATH hits to absolute drive paths", () => {
const expected = "D:\\analysis\\bin\\rizin.EXE";
expect(
resolveWindowsProviderExecutable(
"rizin",
{ PATH: ".\\bin", PATHEXT: ".EXE" },
windowsLookup("D:\\analysis", [expected]),
),
).toBe(expected);
});
it("skips script extensions and preserves a caller-selected absolute path", () => {
const expected = "C:\\tools\\rizin.EXE";
const selected = "C:\\tools\\rizin.exe";
expect(
resolveWindowsProviderExecutable(
"rizin",
{ PATH: "C:\\tools", PATHEXT: ".CMD;.BAT;.EXE;.COM" },
windowsLookup("C:\\work", ["C:\\tools\\rizin.CMD", expected]),
),
).toBe(expected);
expect(
resolveWindowsProviderExecutable(
selected,
{},
windowsLookup("D:\\work", []),
),
).toBe(selected);
});
it("keeps unresolved bare command names unchanged", () => {
expect(
resolveWindowsProviderExecutable(
"missing-tool",
{ PATH: ".\\tools", PATHEXT: ".EXE" },
windowsLookup("C:\\work", []),
),
).toBe("missing-tool");
});
it("passes an absolute selected command through provider composition", () => {
const commands = createReverseEngineeringCommandPort(
{ REA_OBJDUMP_COMMAND: "C:\\tools\\objdump.exe" },
"win32",
);
expect(
commands.objdump({ path: "artifact", operation: "file_headers" })
.executable,
).toBe("C:\\tools\\objdump.exe");
});
});