Kaoru0822andClaude Opus 5.5
289aef6838
* fix(managed): keep caller-input details in managed workflow errors
The managed workflows wrapped every rejected input as
`new AnalysisInputError(op, { cause })` with no issues. The projected
result said "Correct the listed arguments and retry" and listed nothing:
- `rea import-managed-reconstruction`,
`rea project-managed-application-graph` and
`rea verify-managed-native-boundaries` lost every schema issue for
malformed JSON;
- domain checks such as a reconstruction text hash mismatch, or Evidence
from the wrong operation, lost their message on CLI and MCP;
- `rea compare-managed-members` with a missing file did not say which
path failed.
Add managedInputError, which projects Zod issues with their paths and
keeps a domain TypeError's message, as the JavaScript workflows already
do. Return the BinaryTargetError from an unopenable comparison path
unchanged, with details.path, as every other path-based command does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(managed): keep nested Evidence schema issues off request paths
A ZodError raised after the request parsed comes from a nested
Evidence result, so its issue paths are relative to that result.
Projecting it against the whole request reported, for example,
artifact.sha256 as a missing request field. Keep request-relative
projection for the raw request's schema failures. Report nested schema
failures as root issues whose message names the nested location.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(managed): type the malformed nested Evidence fixture
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(workflows): keep input details in the remaining workflow services
Inventory projection (project_android_application_graph and
project_apple_application_graph), build_reconstruction_obligation_ledger
and evaluate_reconstruction_coverage had the same issue-less
`AnalysisInputError({ cause })` as the managed services. For example,
evaluating coverage for an unknown boundary returned "Correct the listed
arguments" with no issues, dropping "Unknown reconstruction boundary: X"
on CLI and MCP.
Move the helpers to src/application/workflowInputError.ts and use them
for these services: requestInputError for raw request schema failures,
workflowInputError for nested schema and domain constraint failures.
Classification is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
92 lines
3.0 KiB
TypeScript
92 lines
3.0 KiB
TypeScript
import { z } from "zod";
|
|
|
|
import { AnalysisProtocolError } from "../domain/analysisErrorCore.js";
|
|
import { type AnalysisError } from "../domain/analysisErrorBase.js";
|
|
import {
|
|
createEvidence,
|
|
type Evidence,
|
|
type EvidenceProvider,
|
|
type EvidenceSubjectTarget,
|
|
} from "../domain/evidence.js";
|
|
import { jsonValueSchema } from "../domain/jsonValue.js";
|
|
import { err, ok, type Result } from "../domain/result.js";
|
|
import { requestInputError, workflowInputError } from "./workflowInputError.js";
|
|
|
|
interface InventoryProjectionInput {
|
|
readonly inventory_evidence: readonly Evidence[];
|
|
readonly limits?: unknown;
|
|
}
|
|
|
|
interface InventoryProjectionResult {
|
|
readonly root_sha256: string;
|
|
readonly source_evidence_ids: readonly string[];
|
|
readonly limitations: readonly string[];
|
|
}
|
|
|
|
interface InventoryProjectionOptions<
|
|
Input extends InventoryProjectionInput,
|
|
Output extends InventoryProjectionResult,
|
|
> {
|
|
readonly rawInput: unknown;
|
|
readonly schema: z.ZodType<Input>;
|
|
readonly project: (input: Input) => Output;
|
|
readonly operation: string;
|
|
readonly predicateType: string;
|
|
readonly provider: EvidenceProvider;
|
|
readonly subjectFormat: (first: Evidence) => EvidenceSubjectTarget["format"];
|
|
readonly protocolError: string;
|
|
}
|
|
|
|
/** Parse one inventory projection and wrap its deterministic result in Evidence. */
|
|
export const projectInventoryEvidence = <
|
|
Input extends InventoryProjectionInput,
|
|
Output extends InventoryProjectionResult,
|
|
>(
|
|
options: InventoryProjectionOptions<Input, Output>,
|
|
): Result<Evidence, AnalysisError> => {
|
|
const parsed = options.schema.safeParse(options.rawInput);
|
|
if (!parsed.success)
|
|
return err(
|
|
requestInputError(options.operation, parsed.error, options.rawInput),
|
|
);
|
|
try {
|
|
const result = options.project(parsed.data);
|
|
const first = parsed.data.inventory_evidence[0];
|
|
return ok(
|
|
createEvidence(
|
|
first?.subject === null || first?.subject === undefined
|
|
? undefined
|
|
: {
|
|
path: first.subject.local_path,
|
|
sha256: result.root_sha256,
|
|
format: options.subjectFormat(first),
|
|
},
|
|
options.provider,
|
|
{
|
|
predicateType: options.predicateType,
|
|
operation: options.operation,
|
|
parameters: {
|
|
inventory_evidence_ids: [...result.source_evidence_ids],
|
|
...("limits" in parsed.data && parsed.data.limits !== undefined
|
|
? { limits: jsonValueSchema.parse(parsed.data.limits) }
|
|
: {}),
|
|
},
|
|
result: jsonValueSchema.parse(result),
|
|
rawResult: null,
|
|
confidence: "inferred",
|
|
authority: "analyst-inference",
|
|
environment: null,
|
|
limitations: result.limitations,
|
|
evidenceLinks: result.source_evidence_ids,
|
|
},
|
|
),
|
|
);
|
|
} catch (cause: unknown) {
|
|
return err(
|
|
cause instanceof TypeError || cause instanceof z.ZodError
|
|
? workflowInputError(options.operation, cause)
|
|
: new AnalysisProtocolError(options.protocolError, { cause }),
|
|
);
|
|
}
|
|
};
|