morluto
dd0015aaf1
Read bounded regular registrations asynchronously with retained descriptor cleanup. Carry the selected parsed configuration through provider factories and restoration, preserve exact cancellation reasons, and share workspace-parent resolution with doctor checks. Closes #5561 Closes #5559 Closes #5604
465 lines
16 KiB
JavaScript
465 lines
16 KiB
JavaScript
#!/usr/bin/env node
|
|
import {
|
|
assertFeatureTrace,
|
|
findMappedNonFunction,
|
|
} from "./lib/ida-feature-trace.mjs";
|
|
import { requireMcpToolError } from "./lib/mcp-verifier-results.mjs";
|
|
import { withVerifierResourceOwner } from "./lib/verifier-file-resources.mjs";
|
|
|
|
import assert from "node:assert/strict";
|
|
import { execFile } from "node:child_process";
|
|
import { createHash } from "node:crypto";
|
|
import { createReadStream } from "node:fs";
|
|
import { access, writeFile } from "node:fs/promises";
|
|
import { basename, dirname, join, resolve } from "node:path";
|
|
import { fileURLToPath, pathToFileURL } from "node:url";
|
|
import { parseArgs, promisify } from "node:util";
|
|
import { Client } from "@modelcontextprotocol/client";
|
|
import { StdioClientTransport } from "@modelcontextprotocol/client/stdio";
|
|
|
|
const { values } = parseArgs({
|
|
options: {
|
|
target: { type: "string" },
|
|
procedure: { type: "string", default: "rea_fixture_add" },
|
|
"second-procedure": { type: "string" },
|
|
"second-marker": { type: "string" },
|
|
"expected-string": { type: "string" },
|
|
"expected-xref": { type: "string" },
|
|
"package-root": { type: "string" },
|
|
report: { type: "string" },
|
|
},
|
|
});
|
|
if (values.target === undefined || process.env.REA_IDA_MCP_CONFIG === undefined)
|
|
throw new Error(
|
|
"IDA verification requires --target and REA_IDA_MCP_CONFIG; see docs/ida-provider.md. No toolchain is installed by this lane.",
|
|
);
|
|
if (
|
|
(values["second-procedure"] === undefined) !==
|
|
(values["second-marker"] === undefined) ||
|
|
values["second-marker"] === ""
|
|
)
|
|
throw new Error(
|
|
"IDA verification requires --second-procedure and a nonempty --second-marker together; choose a marker unique to the second function's pseudocode.",
|
|
);
|
|
if (values["expected-string"] === "" || values["expected-xref"] === "")
|
|
throw new Error("IDA verification oracles must be nonempty.");
|
|
const packageRoot = resolve(
|
|
values["package-root"] ?? fileURLToPath(new URL("..", import.meta.url)),
|
|
);
|
|
const target = resolve(values.target);
|
|
const entry = join(packageRoot, "scripts", "rea.mjs");
|
|
const importBuilt = (path) =>
|
|
import(pathToFileURL(join(packageRoot, "dist", path)).href);
|
|
const [
|
|
{ toolContract },
|
|
{ evidenceSchema },
|
|
{ functionDossierSchema },
|
|
{ readIdaConfiguration },
|
|
{ createIdaMcpConnection },
|
|
{ idaAddressSchema },
|
|
] = await Promise.all([
|
|
importBuilt("contracts/toolContracts.js"),
|
|
importBuilt("domain/evidence.js"),
|
|
importBuilt("domain/hopperValues.js"),
|
|
importBuilt("ida/IdaConfiguration.js"),
|
|
importBuilt("ida/IdaMcpConnection.js"),
|
|
importBuilt("ida/IdaProtocolValues.js"),
|
|
]);
|
|
const config = await withVerifierResourceOwner(async (resourceScope) => {
|
|
const registration = await readIdaConfiguration(
|
|
process.env.REA_IDA_MCP_CONFIG,
|
|
{ resourceScope },
|
|
);
|
|
if (!registration.ok) throw registration.error;
|
|
return registration.value;
|
|
});
|
|
if (
|
|
config.protocol === "native" &&
|
|
(values["second-procedure"] === undefined ||
|
|
values["second-marker"] === undefined)
|
|
)
|
|
throw new Error(
|
|
"Native IDA verification requires --second-procedure and --second-marker to verify distinct-function switching; see docs/ida-provider.md.",
|
|
);
|
|
const environment = Object.fromEntries(
|
|
Object.entries({
|
|
...process.env,
|
|
REA_ANALYSIS_PROVIDER: "ida",
|
|
REA_LOG_LEVEL: "error",
|
|
}).filter(([, value]) => value !== undefined),
|
|
);
|
|
const report = {
|
|
passed: false,
|
|
mode: config.mode,
|
|
protocol:
|
|
config.protocol ?? (config.mode === "attached" ? "legacy" : "modern"),
|
|
checks: [],
|
|
observations: [],
|
|
unverified: [],
|
|
};
|
|
const expectedXref =
|
|
values["expected-xref"] === undefined
|
|
? undefined
|
|
: idaAddressSchema.parse(values["expected-xref"]);
|
|
let phase = "target admission";
|
|
const workspaces = new Set();
|
|
const databases = new Set();
|
|
const digest = async () => {
|
|
const hash = createHash("sha256");
|
|
for await (const chunk of createReadStream(target)) hash.update(chunk);
|
|
return hash.digest("hex");
|
|
};
|
|
const observe = (input) => {
|
|
const evidence = evidenceSchema.parse(input);
|
|
assert.equal(evidence.provider.id, "ida");
|
|
assert.equal(evidence.provider.version, "1");
|
|
assert.equal(evidence.analysis_profile.parameters.cache_policy, "live");
|
|
assert.equal(evidence.analysis_profile.parameters.engine_version, null);
|
|
assert.ok(evidence.limitations.length > 0);
|
|
if (config.protocol === "native" && evidence.operation === "analyze_function")
|
|
assert.equal(evidence.relationship_coverage?.status, "unknown");
|
|
assert.ok(
|
|
evidence.locations.some((location) => location.kind === "artifact-path"),
|
|
);
|
|
if (config.mode === "headless") {
|
|
assert.notEqual(evidence.raw_result.metadata_before.input_path, target);
|
|
workspaces.add(dirname(evidence.raw_result.metadata_before.input_path));
|
|
for (const observation of evidence.raw_result.observations) {
|
|
assert.equal(typeof observation.arguments.database, "string");
|
|
databases.add(observation.arguments.database);
|
|
}
|
|
}
|
|
report.observations.push(evidence);
|
|
return evidence.normalized_result;
|
|
};
|
|
const cli = async () => {
|
|
phase = "production CLI function analysis";
|
|
const { stdout } = await promisify(execFile)(
|
|
process.execPath,
|
|
[
|
|
entry,
|
|
"function",
|
|
target,
|
|
values.procedure,
|
|
"--provider",
|
|
"ida",
|
|
"--json",
|
|
],
|
|
{
|
|
env: environment,
|
|
timeout: config.timeoutMs * 3,
|
|
maxBuffer: 16 * 1024 * 1024,
|
|
},
|
|
).catch((cause) => {
|
|
report.failed_cli = { stdout: cause.stdout, stderr: cause.stderr };
|
|
throw cause;
|
|
});
|
|
const dossier = functionDossierSchema.parse(observe(JSON.parse(stdout)));
|
|
assert.ok(dossier.pseudocode.length > 0);
|
|
assert.ok(dossier.assembly.length > 0);
|
|
assert.equal(dossier.procedure.body.available, false);
|
|
report.checks.push("production CLI and complete function Evidence");
|
|
return dossier;
|
|
};
|
|
const mcp = async (cliDossier) => {
|
|
const client = new Client({ name: "rea-real-ida-verifier", version: "1" });
|
|
const transport = new StdioClientTransport({
|
|
command: process.execPath,
|
|
args: [entry, "mcp"],
|
|
env: environment,
|
|
stderr: "pipe",
|
|
});
|
|
transport.stderr?.on("data", () => undefined);
|
|
const call = async (name, args) => {
|
|
phase = `production MCP ${name}`;
|
|
const result = await client.callTool(
|
|
{ name, arguments: args },
|
|
{ timeout: config.timeoutMs * 2 },
|
|
);
|
|
if (result.isError === true) report.failed_tool_result = result;
|
|
assert.notEqual(result.isError, true);
|
|
return toolContract(name).outputSchema.parse(result.structuredContent);
|
|
};
|
|
let opened = false;
|
|
try {
|
|
await client.connect(transport, { timeout: config.timeoutMs });
|
|
await call("open_binary", { path: target, provider_id: "ida" });
|
|
opened = true;
|
|
const analyzed = await call("analyze_function", {
|
|
procedure: values.procedure,
|
|
});
|
|
const dossier = functionDossierSchema.parse(observe(analyzed));
|
|
assert.deepEqual(dossier.procedure, cliDossier.procedure);
|
|
assert.equal(dossier.pseudocode, cliDossier.pseudocode);
|
|
assert.deepEqual(dossier.assembly, cliDossier.assembly);
|
|
assert.equal(analyzed.operation, "analyze_function");
|
|
for (const [name, args] of [
|
|
["list_procedures", {}],
|
|
["list_strings", {}],
|
|
["procedure_address", { procedure: dossier.procedure.name }],
|
|
["procedure_assembly", { procedure: dossier.procedure.address }],
|
|
["procedure_callees", { procedure: dossier.procedure.address }],
|
|
...(config.mode === "attached" && config.protocol !== "native"
|
|
? [["procedure_callers", { procedure: dossier.procedure.address }]]
|
|
: []),
|
|
["search_procedures", { pattern: dossier.procedure.name }],
|
|
["procedure_pseudo_code", { procedure: dossier.procedure.address }],
|
|
["read_function_instructions", { procedure: dossier.procedure.address }],
|
|
[
|
|
"search_strings",
|
|
{
|
|
pattern: values["expected-string"] ?? "a.b",
|
|
mode: "literal",
|
|
case_sensitive: true,
|
|
},
|
|
],
|
|
["xrefs", { address: dossier.procedure.address }],
|
|
]) {
|
|
const result = await call(name, args);
|
|
const value = observe(result);
|
|
switch (name) {
|
|
case "list_procedures":
|
|
case "search_procedures":
|
|
assert.ok(
|
|
value.some(
|
|
(item) =>
|
|
item.address === dossier.procedure.address &&
|
|
item.value === dossier.procedure.name,
|
|
),
|
|
`${name} omitted the resolved procedure.`,
|
|
);
|
|
break;
|
|
case "procedure_address":
|
|
assert.equal(value, dossier.procedure.address);
|
|
break;
|
|
case "procedure_assembly":
|
|
assert.equal(value, dossier.assembly.join("\n"));
|
|
break;
|
|
case "procedure_pseudo_code":
|
|
assert.equal(value, dossier.pseudocode);
|
|
break;
|
|
case "procedure_callers":
|
|
case "procedure_callees": {
|
|
const expected =
|
|
name === "procedure_callers" ? dossier.callers : dossier.callees;
|
|
assert.deepEqual(
|
|
[...value].sort(),
|
|
expected.map((item) => item.address).sort(),
|
|
);
|
|
break;
|
|
}
|
|
case "read_function_instructions":
|
|
assert.deepEqual(value.procedure.address, dossier.procedure.address);
|
|
assert.deepEqual(value.instructions, dossier.assembly);
|
|
break;
|
|
case "list_strings":
|
|
case "search_strings":
|
|
if (values["expected-string"] !== undefined)
|
|
assert.ok(
|
|
value.some((item) =>
|
|
item.value.includes(values["expected-string"]),
|
|
),
|
|
`${name} omitted the expected literal.`,
|
|
);
|
|
break;
|
|
case "xrefs":
|
|
if (expectedXref !== undefined)
|
|
assert.ok(
|
|
value.includes(expectedXref),
|
|
"xrefs omitted the expected source address.",
|
|
);
|
|
break;
|
|
}
|
|
}
|
|
if (config.mode === "headless") {
|
|
const documents = observe(await call("list_documents", {}));
|
|
assert.equal(documents.length, 1);
|
|
assert.equal(basename(documents[0]), basename(target));
|
|
assert.ok(
|
|
!workspaces.has(dirname(documents[0])),
|
|
"list_documents reported the private workspace copy.",
|
|
);
|
|
const resolveAt = async (address) =>
|
|
observe(await call("resolve_containing_procedure", { address }));
|
|
const instructionAddresses = dossier.assembly
|
|
.map((line) => /^(0x[0-9a-f]+)/iu.exec(line)?.[1])
|
|
.filter((address) => address !== undefined);
|
|
const queries = [
|
|
dossier.procedure.address,
|
|
...instructionAddresses.slice(1, 2),
|
|
];
|
|
for (const queried of queries) {
|
|
const containing = await resolveAt(queried);
|
|
assert.equal(containing.found, true);
|
|
assert.equal(containing.procedure.address, dossier.procedure.address);
|
|
assert.equal(containing.procedure.name, dossier.procedure.name);
|
|
}
|
|
const unmapped = await resolveAt("0xffffffffffffff00");
|
|
assert.equal(unmapped.found, false);
|
|
assert.equal(unmapped.reason, "outside_segments");
|
|
const strings = observe(await call("list_strings", {}));
|
|
const mappedString = await findMappedNonFunction(strings, resolveAt);
|
|
if (mappedString === undefined)
|
|
report.unverified.push(
|
|
"Mapped non-function containment: no string of the target is mapped outside every function.",
|
|
);
|
|
const context = await client.callTool({
|
|
name: "inspect_address_context",
|
|
arguments: { address: dossier.procedure.address },
|
|
});
|
|
assert.notEqual(context.isError, true);
|
|
const contextResult = context.structuredContent.result;
|
|
assert.equal(contextResult.document, documents[0]);
|
|
assert.equal(contextResult.procedure.state, "available");
|
|
assert.equal(
|
|
contextResult.procedure.value.procedure.address,
|
|
dossier.procedure.address,
|
|
);
|
|
const traced = await client.callTool({
|
|
name: "trace_feature",
|
|
arguments: { query: dossier.procedure.name },
|
|
});
|
|
assert.notEqual(traced.isError, true);
|
|
const trace = traced.structuredContent.normalized_result;
|
|
assertFeatureTrace(trace, dossier.procedure);
|
|
report.checks.push(
|
|
"headless containing procedures, the admitted program as the document, address context, and the procedure match and references of feature tracing",
|
|
);
|
|
}
|
|
if (values["expected-string"] === undefined)
|
|
report.unverified.push(
|
|
"String inventory/search correctness: no independent expected literal supplied.",
|
|
);
|
|
else
|
|
report.checks.push(
|
|
"string inventory and literal search contain the expected literal",
|
|
);
|
|
if (expectedXref === undefined)
|
|
report.unverified.push(
|
|
"Xref correctness: no independent expected source address supplied.",
|
|
);
|
|
else report.checks.push("xrefs contain the expected source address");
|
|
if (values["second-procedure"] !== undefined) {
|
|
const secondAddress = observe(
|
|
await call("procedure_address", {
|
|
procedure: values["second-procedure"],
|
|
}),
|
|
);
|
|
assert.notEqual(secondAddress, dossier.procedure.address);
|
|
const secondCode = observe(
|
|
await call("procedure_pseudo_code", {
|
|
procedure: values["second-procedure"],
|
|
}),
|
|
);
|
|
assert.equal(typeof secondCode, "string");
|
|
assert.ok(secondCode.length > 0);
|
|
assert.ok(
|
|
!dossier.pseudocode.includes(values["second-marker"]),
|
|
"The second marker also appears in the first function's pseudocode.",
|
|
);
|
|
assert.ok(
|
|
secondCode.includes(values["second-marker"]),
|
|
"The second function's pseudocode omitted its expected marker.",
|
|
);
|
|
const restored = observe(
|
|
await call("procedure_pseudo_code", {
|
|
procedure: dossier.procedure.address,
|
|
}),
|
|
);
|
|
assert.equal(restored, dossier.pseudocode);
|
|
report.checks.push(
|
|
"second-function pseudocode identity and return to the original function",
|
|
);
|
|
}
|
|
const invalid = await client.callTool({
|
|
name: "xrefs",
|
|
arguments: { address: "not-an-address" },
|
|
});
|
|
assert.equal(invalid.isError, true);
|
|
assert.equal(requireMcpToolError(invalid).code, "invalid_request");
|
|
await call("close_binary", {});
|
|
opened = false;
|
|
report.checks.push(
|
|
"one MCP connection, positive procedure inventory/search, contract-valid tool results, invalid input, and close",
|
|
);
|
|
report.checks.push(
|
|
"CLI/MCP function identity, pseudocode, assembly, instructions, and relationship parity",
|
|
);
|
|
} finally {
|
|
const completedPhase = phase;
|
|
if (opened) await call("close_binary", {});
|
|
await client.close();
|
|
phase = completedPhase;
|
|
}
|
|
};
|
|
const cleanup = async () => {
|
|
phase = "upstream lifecycle verification";
|
|
const upstream = createIdaMcpConnection(config, process.env);
|
|
try {
|
|
await upstream.connect();
|
|
if (config.mode === "attached") {
|
|
const metadata =
|
|
config.protocol === "native"
|
|
? await upstream.readResource("ida://idb/metadata")
|
|
: await upstream.call("get_metadata", {});
|
|
assert.equal(metadata.sha256.toLowerCase(), await digest());
|
|
report.checks.push(
|
|
"existing GUI target remains open with the original input identity",
|
|
);
|
|
} else {
|
|
const inventory = await upstream.call("idb_list", {});
|
|
assert.ok(
|
|
inventory.sessions.every(
|
|
(session) => !databases.has(session.session_id),
|
|
),
|
|
);
|
|
for (const workspace of workspaces)
|
|
await assert.rejects(access(workspace), { code: "ENOENT" });
|
|
report.checks.push(
|
|
"owned database IDs absent from upstream discovery and private workspaces removed",
|
|
);
|
|
}
|
|
} finally {
|
|
await upstream.close();
|
|
}
|
|
};
|
|
try {
|
|
const before = await digest();
|
|
await mcp(await cli());
|
|
await cleanup();
|
|
assert.equal(await digest(), before);
|
|
report.checks.push("original binary unchanged and never executed");
|
|
report.passed = true;
|
|
} catch (cause) {
|
|
report.failure = {
|
|
phase,
|
|
message: cause instanceof Error ? cause.message : String(cause),
|
|
};
|
|
process.exitCode = 1;
|
|
} finally {
|
|
if (values.report !== undefined)
|
|
await writeFile(
|
|
resolve(values.report),
|
|
`${JSON.stringify(report, null, 2)}\n`,
|
|
{ mode: 0o600 },
|
|
);
|
|
console.log(
|
|
JSON.stringify(
|
|
{
|
|
passed: report.passed,
|
|
mode: report.mode,
|
|
checks: report.checks,
|
|
unverified: report.unverified,
|
|
...(report.passed
|
|
? {}
|
|
: {
|
|
failed_phase: phase,
|
|
detail: "Use --report for private local diagnostics.",
|
|
}),
|
|
},
|
|
null,
|
|
2,
|
|
),
|
|
);
|
|
}
|