* fix(browser): name web-bundle budgets and recover web deadlines Name the existing heap, per-script, and total web-bundle phases, and reject a per-script deadline above the total. Promote capture, CDP command, source-map decode, and source-map fetch deadlines at today's defaults. Name DevTools timeoutMs, and state that discovery, cleanup grace, byte budgets, and Electron hook retention have no runtime override. Refs #5910 Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(browser): apply selected web deadlines to the owning phase Keep HTTP and browser-socket discovery on the fixed discovery deadline so a short command_timeout_ms starts at the handshake. Apply scenario command_timeout_ms to launch startup and the primary connect session, and keep service-worker restoration on the fixed 5000 ms grace. Omit command_timeout_ms from recovery text when the operation does not accept it. Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(browser): retain scenario commands that finish after their deadline A timed-out scenario command stays owned so cleanup can close a late browser or context and restore a mutation that lands after the deadline. Child storage replies use that deadline, scenario recovery names command_timeout_ms in the capture JSON, and the session test connection implements beginCleanupGrace. Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(browser): keep child command timeouts as the public failure A nested command such as Page.enable that is delivered but never answered was stored as protocol_error, hiding the command name, selected deadline, and recovery. Store the typed timeout and assert that public error. Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(browser): keep runtime cleanup on the fixed grace Switch runtime restoration to the cleanup grace before the first send so a short command_timeout_ms cannot fail an otherwise successful observation. Stop advertising command_timeout_ms on list_browser_targets, which never bounds a post-discovery command. Co-authored-by: morluto <morluto@users.noreply.github.com> * test(browser): prove a short command deadline cannot fail runtime cleanup Drive restoration through the runtime fixture. A cleanup command that outlives command_timeout_ms still succeeds, and a stalled restoration names the fixed 5000 ms grace. Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(browser): name the effective source-map decode deadline codecBudgetLimitation reported a fixed 20-second deadline after a caller selected decode_timeout_ms. Result and Evidence limitations now name that effective millisecond deadline. Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(browser): separate handshake and target-attach deadlines A browser-level Target.attachToTarget no longer shares the WebSocket handshake budget. Blocked service-worker attachment keeps discovery on its fixed deadline and applies command_timeout_ms to the later handshake and attach. Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(browser): name the web-bundle resource each runtime exhausts Bun ignores the V8 old-space flag. A Windows Job reports the process commit limit, and other Bun hosts no longer suggest raising max_heap_mb. Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(browser): cite the browser-socket discovery message budget WebSocket discovery enforces the 64 MiB protocol budget. Timeout recovery no longer advertises the 8 MiB HTTP document budget. Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(browser): bound the blocked service-worker check before discovery The first registration check has its own fixed 10s deadline. Discovery, handshake, and Target.attachToTarget stay on their separate deadlines. Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(browser): name the operand that stopped web-bundle admission Host heap pressure no longer claims the fixed result budget is exhausted. A Windows Bun allocation before the commit limit still names that limit. Co-authored-by: morluto <morluto@users.noreply.github.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: morluto <morluto@users.noreply.github.com>
179 lines
5.5 KiB
TypeScript
179 lines
5.5 KiB
TypeScript
import { readFile } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
|
|
import { describe, expect } from "vitest";
|
|
|
|
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
|
|
import {
|
|
processTest as it,
|
|
waitForExit,
|
|
} from "../../support/process/processFixture.js";
|
|
|
|
import {
|
|
BROWSER_DEVTOOLS_STARTUP_TIMEOUT_MS,
|
|
BrowserStartupError,
|
|
waitForBrowserDevtoolsPort,
|
|
} from "../../../src/browser/BrowserProcessStartup.js";
|
|
import { assertOrdinaryWindowsVerifierCaller } from "../../../scripts/lib/windows-ordinary-user-verifier.mjs";
|
|
|
|
describe("browser process startup", () => {
|
|
it("requires a positively observed ordinary Windows verifier caller", () => {
|
|
expect(() =>
|
|
assertOrdinaryWindowsVerifierCaller({
|
|
administrator: false,
|
|
elevated: false,
|
|
integrityLevel: 8192,
|
|
}),
|
|
).not.toThrow();
|
|
|
|
for (const token of [
|
|
{ administrator: true, elevated: false },
|
|
{ administrator: false, elevated: true },
|
|
{ administrator: false },
|
|
{ administrator: false, elevated: null },
|
|
null,
|
|
]) {
|
|
expect(() => assertOrdinaryWindowsVerifierCaller(token)).toThrow(
|
|
/ordinary, non-elevated user token/u,
|
|
);
|
|
}
|
|
});
|
|
|
|
it("returns a delayed valid DevToolsActivePort", async ({ processes }) => {
|
|
const root = await temporaryRoot();
|
|
const portPath = join(root, "DevToolsActivePort");
|
|
const child = processes.spawn(process.execPath, [
|
|
"-e",
|
|
`setTimeout(() => require("node:fs").writeFileSync(${JSON.stringify(portPath)}, "43117\\n/browser"), 20); setTimeout(() => {}, 1000)`,
|
|
]);
|
|
try {
|
|
await expect(
|
|
waitForBrowserDevtoolsPort({
|
|
child,
|
|
executable: process.execPath,
|
|
activePortPath: portPath,
|
|
stderr: () => "",
|
|
timeoutMs: 1_000,
|
|
pollIntervalMs: 5,
|
|
}),
|
|
).resolves.toBe(43_117);
|
|
} finally {
|
|
child.kill("SIGKILL");
|
|
expect(await waitForExit(child, 5_000)).toBe(true);
|
|
}
|
|
});
|
|
|
|
it("classifies signal termination instead of timing out", async ({
|
|
processes,
|
|
}) => {
|
|
const root = await temporaryRoot();
|
|
const child = processes.spawn(process.execPath, [
|
|
"-e",
|
|
"process.kill(process.pid, 'SIGTERM')",
|
|
]);
|
|
|
|
const failure = await waitForBrowserDevtoolsPort({
|
|
child,
|
|
executable: process.execPath,
|
|
activePortPath: join(root, "DevToolsActivePort"),
|
|
stderr: () => "signal fixture",
|
|
timeoutMs: 1_000,
|
|
pollIntervalMs: 5,
|
|
}).catch((cause: unknown) => cause);
|
|
|
|
expect(failure).toBeInstanceOf(BrowserStartupError);
|
|
expect(failure).toMatchObject({
|
|
failure: "signalled",
|
|
exitCode: null,
|
|
signalCode: "SIGTERM",
|
|
stderr: "signal fixture",
|
|
});
|
|
});
|
|
|
|
it("reports bounded timeout diagnostics", async ({ processes }) => {
|
|
const root = await temporaryRoot();
|
|
const child = processes.spawn(process.execPath, [
|
|
"-e",
|
|
"setTimeout(() => {}, 1000)",
|
|
]);
|
|
try {
|
|
const failure = await waitForBrowserDevtoolsPort({
|
|
child,
|
|
executable: process.execPath,
|
|
activePortPath: join(root, "DevToolsActivePort"),
|
|
stderr: () => "",
|
|
timeoutMs: 20,
|
|
pollIntervalMs: 5,
|
|
}).catch((cause: unknown) => cause);
|
|
|
|
expect(failure).toBeInstanceOf(BrowserStartupError);
|
|
expect(failure).toMatchObject({
|
|
failure: "timeout",
|
|
exitCode: null,
|
|
signalCode: null,
|
|
startupTimeoutMs: 20,
|
|
});
|
|
expect(String(failure)).toContain("stderr=<empty>");
|
|
expect(String(failure)).toContain("timeoutMs=20");
|
|
} finally {
|
|
child.kill("SIGKILL");
|
|
expect(await waitForExit(child, 5_000)).toBe(true);
|
|
}
|
|
});
|
|
|
|
it("names the owner's deadline when a caller omits one", async ({
|
|
processes,
|
|
}) => {
|
|
const root = await temporaryRoot();
|
|
const child = processes.spawn(process.execPath, [
|
|
"-e",
|
|
"setTimeout(() => process.exit(3), 10)",
|
|
]);
|
|
|
|
const failure = await waitForBrowserDevtoolsPort({
|
|
child,
|
|
executable: process.execPath,
|
|
activePortPath: join(root, "DevToolsActivePort"),
|
|
stderr: () => "owner default fixture",
|
|
pollIntervalMs: 5,
|
|
}).catch((cause: unknown) => cause);
|
|
|
|
expect(failure).toBeInstanceOf(BrowserStartupError);
|
|
expect(failure).toMatchObject({
|
|
failure: "exited",
|
|
startupTimeoutMs: BROWSER_DEVTOOLS_STARTUP_TIMEOUT_MS,
|
|
});
|
|
expect(String(failure)).toContain(
|
|
`timeoutMs=${String(BROWSER_DEVTOOLS_STARTUP_TIMEOUT_MS)}`,
|
|
);
|
|
});
|
|
|
|
it("keeps one owner for the DevToolsActivePort deadline", async () => {
|
|
expect(BROWSER_DEVTOOLS_STARTUP_TIMEOUT_MS).toBe(60_000);
|
|
const callers = [
|
|
"../../../scripts/verify-real-browser.mjs",
|
|
"../../../scripts/lib/browser-runtime-fixture-lifecycle.mjs",
|
|
];
|
|
for (const caller of callers) {
|
|
const source = await readFile(new URL(caller, import.meta.url), "utf8");
|
|
expect(devtoolsPortDeadlines(source)).toEqual([
|
|
["BROWSER_DEVTOOLS_STARTUP_TIMEOUT_MS"],
|
|
]);
|
|
}
|
|
});
|
|
});
|
|
|
|
const temporaryRoot = async (): Promise<string> => {
|
|
return createTestTempDirectory("rea-browser-startup-");
|
|
};
|
|
|
|
const devtoolsPortDeadlines = (source: string): string[][] => {
|
|
const calls = /waitForBrowserDevtoolsPort\(\{(?<body>[\s\S]*?)\}\)/gu;
|
|
const deadlines = /\btimeoutMs:\s*(?<value>[^\n,]+)/gu;
|
|
return [...source.matchAll(calls)].map((call) =>
|
|
[...String(call.groups?.body).matchAll(deadlines)].map((deadline) =>
|
|
String(deadline.groups?.value).trim(),
|
|
),
|
|
);
|
|
};
|