* feat(process): add owned debugger shutdown lifecycle * feat(reverse): add local inspection commands * feat(gdb): add persistent debugger integration * feat(cutter): add Cutter bridge integration * test(reverse): enforce complete integration coverage * fix(process): preserve debugger shutdown ownership * fix(reverse): retain evidence across interrupted commands * fix(gdb): honor captured provider environment * test(process): cover debugger shutdown retries * fix(reverse): retain evidence for interrupted providers * test(process): cover debugger shutdown retries * fix(reverse): retain evidence for interrupted providers * fix(server): snapshot provider environment at creation * fix(reverse): close review gaps with complete coverage * fix(reverse): address inspection review findings * fix(gdb): bound sessions and retain cleanup ownership * fix(ci): require reverse-tools quality lane * fix(process): unref inherited debugger output pipes * fix(reverse): address remaining PR 1960 findings * fix(gdb): address remaining PR 1961 findings * fix(reverse): account for unrestricted provider execution * fix(process): retain debugger ownership until safe shutdown * fix(process): preserve replacement debugger sessions * fix(reverse): preserve admission and output provenance * fix(process): retain exited debugger until output settles * fix(mcp): bound provider admission and debugger cleanup * fix(reverse): preserve failure provenance and classify E2BIG * fix(gdb): preserve startup cleanup and detach safety * fix(process): retain debugger ownership after detach failure * fix(reverse): preserve mutation and failure provenance * fix(gdb): address debugger review findings * fix(reverse): rebind sessions after external mutation * fix(process): cap debugger output after exit * fix(gdb): protect one-shot detach verification * feat(debugger): add reverse tool coverage gate * test(debugger): cover integrated failure paths * fix(gdb): bound and preserve session observations * fix(gdb): address review regressions * style: format merged integration files * fix(reverse): preserve session and output evidence * refactor(gdb): share repeated test and partial result setup * fix(gdb): invalidate TTY proof for Python aliases * fix(reverse): retain failure output byte counts * test(process): synchronize late debugger output * fix(gdb): invalidate TTY proof for wrapped commands * fix(gdb): recognize wit command abbreviation * test(reverse): wait for cancelled descendant readiness * test(reverse): bound descendant cancellation cleanup * style(reverse): format integration tests and adapters * style: format reverse engineering integration files * test(reverse): remove duplicate environment harness * test(gdb): share session startup assertions * fix(gdb): invalidate output proof for command abbreviations * test(reverse): share composition edge case scenarios * fix(ci): recognize verification and mutation tool entries * test(rizin): cover successful fake inferior detach * test(cli): align full output failure envelope * test(cli): isolate reverse command lifecycle service * test(process): share debugger output fixture setup * fix(binary): preserve high-bit Windows signature bytes * style(binary): format Windows signature parser * test(mcp): preserve call coverage in unchanged comparison * fix(ci): include reverse tools Vitest configs in lint cache * fix(mcp): preserve target content on delivery errors * ci: align duplication ceiling with expanded suite * test(reverse): allow signal admission mutants * fix(reverse): bound retained cleanup failures to process owners * fix(test): replace drifting mutation ranges with owned selectors * fix(reverse): admit persistent commands and retain cleanup ownership * fix(cutter): recover timed-out commands from exact receipts * fix(cutter): reject unsupported bridge request kinds * fix(ci): repair client format and shared verification fixtures * fix(native): preserve debugger cleanup ownership and bridge authentication * test(native): retain diagnostics without perfect coverage requirements * chore(licenses): refresh locked dependency inventory and notices * fix(test): exclude transient command locks from mutation sandboxes * fix(gdb): admit only platforms with safe detach verification * fix(cutter): retain bounded completion receipts until acknowledgement * fix(cutter): acknowledge commands rejected before UI dispatch * test(reverse): fail cancellation checks before fixture teardown * test(gdb): clean up the retained broken-stdin fixture owner * docs(test): clarify focused provider verification scope * fix(rizin): retain close cleanup failures * fix(gdb): wait for inferior stop and bound MI buffering * fix(cutter): retain failed receipt acknowledgements * fix(rizin): return retained session identity on rebind failure * fix(gdb): preserve startup cancellation and lossy status * fix(rizin): retain launch provenance and assemble frames once * fix(cutter): recover receipts across callers and bound discovery * docs: describe debugger evidence and bridge recovery * fix(process): keep cleanup incomplete while writers remain Stopping a debugger no longer reports success when inherited output streams stay open, so BinarySession cannot reopen a binary a child is still changing. Concurrent Cutter cleanup retries share one receipt acknowledgement instead of treating a consumed receipt as failure. * fix(debuggers): recover cleanup with captured process identities * fix(analysis): retire sessions after unrestricted commands * fix(cli): preserve completed evidence after cleanup recovery * fix(cutter): bound frame collection and coalesce cleanup * fix(windows): resolve selected provider paths absolutely * fix(gdb): report decoding loss in failed startup evidence * fix(rizin): scope decoding loss to collected command frames * test(mcp): cover snapshot retirement in reverse tools CI --------- Co-authored-by: Daniel Gonçalves Araujo <47118053+dandgabr@users.noreply.github.com> Co-authored-by: REA Maintainers <noreply@github.com> Co-authored-by: OpenAI Codex <codex@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
133 lines
3.9 KiB
TypeScript
133 lines
3.9 KiB
TypeScript
import pino from "pino";
|
|
import { expect, it, vi } from "vitest";
|
|
|
|
import { AnalysisOutputError } from "../../../src/domain/analysisErrorCore.js";
|
|
import { err } from "../../../src/domain/result.js";
|
|
import { registerReverseEngineeringCommands } from "../../../src/cli/reverseEngineeringCommands.js";
|
|
import { CLI_COMMANDS } from "../../../src/cliCommandNames.js";
|
|
import type { CliInstance } from "../../../src/cli/types.js";
|
|
import type { GdbSessionManager } from "../../../src/gdb/GdbSessionManager.js";
|
|
|
|
const registerGdbCommand = (
|
|
createManager: () => GdbSessionManager,
|
|
): {
|
|
run(input: {
|
|
args: { command: string };
|
|
options: { inferiorTty: string };
|
|
}): Promise<unknown>;
|
|
} => {
|
|
const commands = new Map<
|
|
string,
|
|
{
|
|
run(input: {
|
|
args: { command: string };
|
|
options: { inferiorTty: string };
|
|
}): Promise<unknown>;
|
|
}
|
|
>();
|
|
const cli = {
|
|
command: (
|
|
name: string,
|
|
definition: {
|
|
run(input: {
|
|
args: { command: string };
|
|
options: { inferiorTty: string };
|
|
}): Promise<unknown>;
|
|
},
|
|
) => {
|
|
commands.set(name, definition);
|
|
return cli;
|
|
},
|
|
} as unknown as CliInstance;
|
|
registerReverseEngineeringCommands(cli, pino({ enabled: false }), {}, () =>
|
|
createManager(),
|
|
);
|
|
const command = commands.get(CLI_COMMANDS.debugWithGdb);
|
|
if (command === undefined)
|
|
throw new Error("GDB CLI command was not registered");
|
|
return command;
|
|
};
|
|
|
|
it.each([
|
|
"source /tmp/gdbinit",
|
|
"python print('x')",
|
|
"def custom-command",
|
|
"run > /tmp/out",
|
|
"set inferior-t /dev/null",
|
|
"with inferior-t /dev/null -- run",
|
|
])("rejects one-shot command %s before starting GDB", async (inputCommand) => {
|
|
const manager = {
|
|
start: vi.fn(),
|
|
closeAll: vi.fn(),
|
|
} as unknown as GdbSessionManager;
|
|
const command = registerGdbCommand(() => manager);
|
|
const result = await command.run({
|
|
args: { command: inputCommand },
|
|
options: { inferiorTty: "/dev/pts/42" },
|
|
});
|
|
expect(result).toMatchObject({
|
|
code: "invalid_request",
|
|
details: {
|
|
issues: [
|
|
expect.objectContaining({
|
|
message: expect.stringContaining("persistent GDB session workflow"),
|
|
}),
|
|
],
|
|
},
|
|
});
|
|
expect(manager.start).not.toHaveBeenCalled();
|
|
expect(manager.closeAll).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("retries retained GDB cleanup when CLI session startup fails", async () => {
|
|
const closeAll = vi.fn(async () => undefined);
|
|
const manager = {
|
|
start: vi.fn(async () =>
|
|
err(new AnalysisOutputError("start_gdb_session", "startup failed")),
|
|
),
|
|
closeAll,
|
|
} as unknown as GdbSessionManager;
|
|
const originalExitCode = process.exitCode;
|
|
const command = registerGdbCommand(() => manager);
|
|
|
|
try {
|
|
const result = await command.run({
|
|
args: { command: "info files" },
|
|
options: { inferiorTty: "/dev/pts/42" },
|
|
});
|
|
expect(result).toMatchObject({ code: "unreadable_output" });
|
|
expect(manager.start).toHaveBeenCalledOnce();
|
|
expect(manager.start).toHaveBeenCalledWith(expect.anything(), {
|
|
inferiorTty: "/dev/pts/42",
|
|
});
|
|
expect(closeAll).toHaveBeenCalledOnce();
|
|
} finally {
|
|
process.exitCode = originalExitCode;
|
|
}
|
|
});
|
|
|
|
it("marks the CLI failed when retained GDB cleanup remains incomplete", async () => {
|
|
const manager = {
|
|
start: vi.fn(async () =>
|
|
err(new AnalysisOutputError("start_gdb_session", "startup failed")),
|
|
),
|
|
closeAll: vi.fn(async () => {
|
|
throw new Error("process still owned");
|
|
}),
|
|
} as unknown as GdbSessionManager;
|
|
const originalExitCode = process.exitCode;
|
|
const command = registerGdbCommand(() => manager);
|
|
|
|
try {
|
|
const result = await command.run({
|
|
args: { command: "info files" },
|
|
options: { inferiorTty: "/dev/pts/42" },
|
|
});
|
|
expect(result).toMatchObject({ code: "unreadable_output" });
|
|
expect(manager.closeAll).toHaveBeenCalledOnce();
|
|
expect(process.exitCode).toBe(1);
|
|
} finally {
|
|
process.exitCode = originalExitCode;
|
|
}
|
|
});
|