Files
rea/tests/boundary/mcp/reverseEngineeringEnvironmentMcp.test.ts
T
4aa51bfe19 fix(reverse): reconcile cleanup ownership and mutation diagnostics (#2799)
* feat(process): add owned debugger shutdown lifecycle

* feat(reverse): add local inspection commands

* feat(gdb): add persistent debugger integration

* feat(cutter): add Cutter bridge integration

* test(reverse): enforce complete integration coverage

* fix(process): preserve debugger shutdown ownership

* fix(reverse): retain evidence across interrupted commands

* fix(gdb): honor captured provider environment

* test(process): cover debugger shutdown retries

* fix(reverse): retain evidence for interrupted providers

* test(process): cover debugger shutdown retries

* fix(reverse): retain evidence for interrupted providers

* fix(server): snapshot provider environment at creation

* fix(reverse): close review gaps with complete coverage

* fix(reverse): address inspection review findings

* fix(gdb): bound sessions and retain cleanup ownership

* fix(ci): require reverse-tools quality lane

* fix(process): unref inherited debugger output pipes

* fix(reverse): address remaining PR 1960 findings

* fix(gdb): address remaining PR 1961 findings

* fix(reverse): account for unrestricted provider execution

* fix(process): retain debugger ownership until safe shutdown

* fix(process): preserve replacement debugger sessions

* fix(reverse): preserve admission and output provenance

* fix(process): retain exited debugger until output settles

* fix(mcp): bound provider admission and debugger cleanup

* fix(reverse): preserve failure provenance and classify E2BIG

* fix(gdb): preserve startup cleanup and detach safety

* fix(process): retain debugger ownership after detach failure

* fix(reverse): preserve mutation and failure provenance

* fix(gdb): address debugger review findings

* fix(reverse): rebind sessions after external mutation

* fix(process): cap debugger output after exit

* fix(gdb): protect one-shot detach verification

* feat(debugger): add reverse tool coverage gate

* test(debugger): cover integrated failure paths

* fix(gdb): bound and preserve session observations

* fix(gdb): address review regressions

* style: format merged integration files

* fix(reverse): preserve session and output evidence

* refactor(gdb): share repeated test and partial result setup

* fix(gdb): invalidate TTY proof for Python aliases

* fix(reverse): retain failure output byte counts

* test(process): synchronize late debugger output

* fix(gdb): invalidate TTY proof for wrapped commands

* fix(gdb): recognize wit command abbreviation

* test(reverse): wait for cancelled descendant readiness

* test(reverse): bound descendant cancellation cleanup

* style(reverse): format integration tests and adapters

* style: format reverse engineering integration files

* test(reverse): remove duplicate environment harness

* test(gdb): share session startup assertions

* fix(gdb): invalidate output proof for command abbreviations

* test(reverse): share composition edge case scenarios

* fix(ci): recognize verification and mutation tool entries

* test(rizin): cover successful fake inferior detach

* test(cli): align full output failure envelope

* test(cli): isolate reverse command lifecycle service

* test(process): share debugger output fixture setup

* fix(binary): preserve high-bit Windows signature bytes

* style(binary): format Windows signature parser

* test(mcp): preserve call coverage in unchanged comparison

* fix(ci): include reverse tools Vitest configs in lint cache

* fix(mcp): preserve target content on delivery errors

* ci: align duplication ceiling with expanded suite

* test(reverse): allow signal admission mutants

* fix(reverse): bound retained cleanup failures to process owners

* fix(test): replace drifting mutation ranges with owned selectors

* fix(reverse): admit persistent commands and retain cleanup ownership

* fix(cutter): recover timed-out commands from exact receipts

* fix(cutter): reject unsupported bridge request kinds

* fix(ci): repair client format and shared verification fixtures

* fix(native): preserve debugger cleanup ownership and bridge authentication

* test(native): retain diagnostics without perfect coverage requirements

* chore(licenses): refresh locked dependency inventory and notices

* fix(test): exclude transient command locks from mutation sandboxes

* fix(gdb): admit only platforms with safe detach verification

* fix(cutter): retain bounded completion receipts until acknowledgement

* fix(cutter): acknowledge commands rejected before UI dispatch

* test(reverse): fail cancellation checks before fixture teardown

* test(gdb): clean up the retained broken-stdin fixture owner

* docs(test): clarify focused provider verification scope

* fix(rizin): retain close cleanup failures

* fix(gdb): wait for inferior stop and bound MI buffering

* fix(cutter): retain failed receipt acknowledgements

* fix(rizin): return retained session identity on rebind failure

* fix(gdb): preserve startup cancellation and lossy status

* fix(rizin): retain launch provenance and assemble frames once

* fix(cutter): recover receipts across callers and bound discovery

* docs: describe debugger evidence and bridge recovery

* fix(process): keep cleanup incomplete while writers remain

Stopping a debugger no longer reports success when inherited output
streams stay open, so BinarySession cannot reopen a binary a child is
still changing. Concurrent Cutter cleanup retries share one receipt
acknowledgement instead of treating a consumed receipt as failure.

* fix(debuggers): recover cleanup with captured process identities

* fix(analysis): retire sessions after unrestricted commands

* fix(cli): preserve completed evidence after cleanup recovery

* fix(cutter): bound frame collection and coalesce cleanup

* fix(windows): resolve selected provider paths absolutely

* fix(gdb): report decoding loss in failed startup evidence

* fix(rizin): scope decoding loss to collected command frames

* test(mcp): cover snapshot retirement in reverse tools CI

---------

Co-authored-by: Daniel Gonçalves Araujo <47118053+dandgabr@users.noreply.github.com>
Co-authored-by: REA Maintainers <noreply@github.com>
Co-authored-by: OpenAI Codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-10-14 04:47:34 +08:00

122 lines
4.1 KiB
TypeScript

import { chmod, mkdtemp, writeFile } from "node:fs/promises";
import { tmpdir } from "node:os";
import { join } from "node:path";
import type { Client } from "@modelcontextprotocol/client";
import { expect, it } from "vitest";
import { createProviderEnvironmentMcpHarness } from "../../support/reverseDebuggerMcpTestHelpers.js";
const writeProvider = async (path: string, output: string): Promise<void> => {
await writeFile(
path,
`#!${process.execPath}\nprocess.stdout.write('${output}');\n`,
);
await chmod(path, 0o755);
};
const connectProviderClient = (options: {
readonly directory: string;
readonly clientName: string;
readonly configuredProvider: string;
readonly providerEnvironment?: { REA_RIZIN_COMMAND: string };
}) =>
createProviderEnvironmentMcpHarness({
directory: options.directory,
clientName: options.clientName,
serverOptions: {
environment: { REA_RIZIN_COMMAND: options.configuredProvider },
...(options.providerEnvironment === undefined
? {}
: { providerEnvironment: options.providerEnvironment }),
},
});
const executeRizinCommand = async (
client: Client,
artifact: string,
): Promise<Awaited<ReturnType<Client["callTool"]>>> => {
const response = await client.callTool({
name: "execute_rizin_command",
arguments: { path: artifact, command: "iI" },
});
expect(response.isError).not.toBe(true);
return response;
};
it("uses the captured server environment to resolve reverse-engineering providers", async () => {
const directory = await mkdtemp(join(tmpdir(), "rea-provider-environment-"));
const provider = join(directory, "selected-rizin");
const artifact = join(directory, "fixture.bin");
await writeFile(artifact, "fixture");
await writeProvider(provider, "captured-environment-provider");
const { client } = await connectProviderClient({
directory,
clientName: "reverse-provider-environment",
configuredProvider: provider,
});
const response = await executeRizinCommand(client, artifact);
expect(JSON.stringify(response.structuredContent)).toContain(
"captured-environment-provider",
);
});
it("prefers an explicit provider environment over the captured server environment", async () => {
const directory = await mkdtemp(join(tmpdir(), "rea-provider-override-"));
const configured = join(directory, "captured-rizin");
const override = join(directory, "override-rizin");
const artifact = join(directory, "fixture.bin");
await writeFile(artifact, "fixture");
for (const [path, output] of [
[configured, "captured"],
[override, "explicit-override"],
] as const) {
await writeProvider(path, output);
}
const { client } = await connectProviderClient({
directory,
clientName: "reverse-provider-override",
configuredProvider: configured,
providerEnvironment: { REA_RIZIN_COMMAND: override },
});
const response = await executeRizinCommand(client, artifact);
expect(JSON.stringify(response.structuredContent)).toContain(
"explicit-override",
);
expect(JSON.stringify(response.structuredContent)).not.toContain(
'"captured"',
);
});
it("snapshots an explicit provider environment when the server is created", async () => {
const directory = await mkdtemp(join(tmpdir(), "rea-provider-snapshot-"));
const configured = join(directory, "captured-rizin");
const override = join(directory, "explicit-rizin");
const artifact = join(directory, "fixture.bin");
await writeFile(artifact, "fixture");
for (const [path, output] of [
[configured, "captured"],
[override, "explicit-snapshot"],
] as const) {
await writeProvider(path, output);
}
const providerEnvironment = { REA_RIZIN_COMMAND: override };
const { client } = await connectProviderClient({
directory,
clientName: "reverse-provider-snapshot",
configuredProvider: configured,
providerEnvironment,
});
providerEnvironment.REA_RIZIN_COMMAND = configured;
const response = await executeRizinCommand(client, artifact);
expect(JSON.stringify(response.structuredContent)).toContain(
"explicit-snapshot",
);
expect(JSON.stringify(response.structuredContent)).not.toContain(
'"captured"',
);
});