Bound recent decoded history to complete UTF-8 prefixes and reuse the bounded capture implementation without changing command Evidence or wire queue accounting. Add deterministic Unicode and invalid-byte coverage, and document history retention. Fixes #5091 Fixes #5242 Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
359 lines
12 KiB
TypeScript
359 lines
12 KiB
TypeScript
import { afterEach, expect, it } from "vitest";
|
|
import { evidenceSchema } from "../../../src/domain/evidence.js";
|
|
import { rizinTestInferiorTty } from "./RizinTestInferiorTty.js";
|
|
import {
|
|
createRizinCoverageHarness,
|
|
createInjectedProcess,
|
|
incompleteStop,
|
|
} from "./RizinDebugSessionCoverage.fixtures.js";
|
|
|
|
const { cleanup, makeProvider, start, startInjected, createManager } =
|
|
createRizinCoverageHarness();
|
|
afterEach(cleanup);
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"assembles a multi-chunk NUL frame once and preserves its command output",
|
|
async () => {
|
|
const chunk = Buffer.alloc(64 * 1024, 0x61);
|
|
const chunkCount = 32;
|
|
const outputBytes = chunk.length * chunkCount;
|
|
const injected = createInjectedProcess({
|
|
onWrite: (text, control) => {
|
|
const marker = /!echo (.+)\n/u.exec(text)?.[1];
|
|
if (marker !== undefined)
|
|
setImmediate(() => {
|
|
for (let index = 0; index < chunkCount; index += 1)
|
|
control.output(chunk);
|
|
control.output(Buffer.from([0]));
|
|
control.output(Buffer.from(`${marker}\0`));
|
|
});
|
|
},
|
|
});
|
|
const { manager, started } = await startInjected(injected.spawnProcess, {
|
|
frameTimeoutMs: 1000,
|
|
});
|
|
expect(started.ok).toBe(true);
|
|
if (!started.ok) return;
|
|
|
|
const result = await manager.execute(started.value.session_id, "chunked");
|
|
|
|
expect(result.ok).toBe(true);
|
|
if (result.ok) {
|
|
expect(Buffer.byteLength(result.value.result.output)).toBe(outputBytes);
|
|
expect(result.value.result.output).toBe("a".repeat(outputBytes));
|
|
expect(result.value.result.completion_status).toBe("complete");
|
|
}
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"discards an oversized frame split across deterministic stream chunks",
|
|
async () => {
|
|
const injected = createInjectedProcess({
|
|
onWrite: (text, control) => {
|
|
const marker = /!echo (.+)\n/u.exec(text)?.[1];
|
|
if (marker !== undefined)
|
|
setImmediate(() => {
|
|
control.output(Buffer.alloc(16 * 1024 * 1024 + 1, 0x61));
|
|
control.output(Buffer.from("discard tail"));
|
|
control.output(Buffer.from([0]));
|
|
control.output(Buffer.from(`${marker}\0`));
|
|
});
|
|
},
|
|
});
|
|
const { manager, started } = await startInjected(injected.spawnProcess, {
|
|
frameTimeoutMs: 1000,
|
|
stopProcess: async () => ({ status: "stopped" }),
|
|
});
|
|
expect(started.ok).toBe(true);
|
|
if (!started.ok) return;
|
|
const result = await manager.execute(started.value.session_id, "large");
|
|
expect(result.ok).toBe(true);
|
|
if (result.ok) expect(result.value.result.output_truncated).toBe(true);
|
|
expect(manager.status(started.value.session_id)).toMatchObject({
|
|
recent_output_truncated: true,
|
|
recent_output: expect.arrayContaining([
|
|
"a".repeat(16384) + "[recent frame truncated]",
|
|
]),
|
|
});
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"closes an injected session on an oversized unsolicited frame",
|
|
async () => {
|
|
const injected = createInjectedProcess();
|
|
const { manager, started } = await startInjected(injected.spawnProcess);
|
|
expect(started.ok).toBe(true);
|
|
if (!started.ok) return;
|
|
injected.control.output(Buffer.alloc(16 * 1024 * 1024 + 1, 0x61));
|
|
expect(manager.status(started.value.session_id)?.state).toBe("closed");
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32").each([
|
|
{ name: "empty", bytes: Buffer.alloc(0), prefix: "", truncated: false },
|
|
{
|
|
name: "short CJK",
|
|
bytes: Buffer.from("雪".repeat(10)),
|
|
prefix: "雪".repeat(10),
|
|
truncated: false,
|
|
},
|
|
{
|
|
name: "exact ASCII budget",
|
|
bytes: Buffer.from("a".repeat(16384)),
|
|
prefix: "a".repeat(16384),
|
|
truncated: false,
|
|
},
|
|
{
|
|
name: "oversized ASCII",
|
|
bytes: Buffer.from("a".repeat(17000)),
|
|
prefix: "a".repeat(16384),
|
|
truncated: true,
|
|
},
|
|
{
|
|
name: "two-byte boundary",
|
|
bytes: Buffer.from("a".repeat(16383) + "é"),
|
|
prefix: "a".repeat(16383),
|
|
truncated: true,
|
|
},
|
|
{
|
|
name: "oversized CJK",
|
|
bytes: Buffer.from("雪".repeat(20000)),
|
|
prefix: "雪".repeat(5461),
|
|
truncated: true,
|
|
},
|
|
{
|
|
name: "split emoji boundary",
|
|
bytes: Buffer.from("a".repeat(16383) + "😀" + "x".repeat(100)),
|
|
prefix: "a".repeat(16383),
|
|
truncated: true,
|
|
},
|
|
{
|
|
name: "complete emoji boundary",
|
|
bytes: Buffer.from("a".repeat(16380) + "😀" + "x"),
|
|
prefix: "a".repeat(16380) + "😀",
|
|
truncated: true,
|
|
},
|
|
{
|
|
name: "invalid UTF-8 expansion below the wire budget",
|
|
bytes: Buffer.alloc(6000, 0xff),
|
|
prefix: "\uFFFD".repeat(5461),
|
|
truncated: true,
|
|
invalidUtf8: true,
|
|
},
|
|
])(
|
|
"bounds $name history while preserving complete command Evidence",
|
|
async ({ bytes, prefix, truncated, ...flags }) => {
|
|
const injected = createInjectedProcess({
|
|
onWrite: (text, control) => {
|
|
const marker = /!echo (.+)\n/u.exec(text)?.[1];
|
|
if (marker === undefined) return;
|
|
setImmediate(() => {
|
|
control.output(bytes);
|
|
control.output(Buffer.from([0]));
|
|
control.output(`${marker}\0`);
|
|
});
|
|
},
|
|
});
|
|
const { manager, started } = await startInjected(injected.spawnProcess);
|
|
expect(started.ok).toBe(true);
|
|
if (!started.ok) return;
|
|
|
|
const result = await manager.execute(
|
|
started.value.session_id,
|
|
"history-fixture",
|
|
);
|
|
expect(result.ok).toBe(true);
|
|
if (!result.ok) return;
|
|
const expected = {
|
|
output: bytes.toString("utf8"),
|
|
output_truncated: false,
|
|
completion_status: "complete",
|
|
};
|
|
expect(result.value.evidence).toMatchObject({
|
|
normalized_result: expected,
|
|
raw_result: expected,
|
|
});
|
|
expect(result.value.result.output_invalid_utf8).toBe(
|
|
"invalidUtf8" in flags ? true : undefined,
|
|
);
|
|
|
|
// Exercise unsolicited frames too, without relying on child scheduling.
|
|
injected.control.output(bytes);
|
|
injected.control.output(Buffer.from([0]));
|
|
const status = manager.status(started.value.session_id);
|
|
expect(status?.recent_output_truncated).toBe(truncated);
|
|
expect(status?.output_invalid_utf8).toBe("invalidUtf8" in flags);
|
|
const retained = status?.recent_output.at(-1);
|
|
expect(retained).toBe(
|
|
prefix + (truncated ? "[recent frame truncated]" : ""),
|
|
);
|
|
expect(Buffer.byteLength(retained ?? "", "utf8")).toBeLessThanOrEqual(
|
|
16 * 1024 + 24,
|
|
);
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"bounds recent history after many unsolicited frames",
|
|
async () => {
|
|
const provider = await makeProvider(
|
|
'process.stdout.write("\\0" + Array.from({ length: 70 }, (_, i) => "frame" + i + "\\0").join("")); process.stdin.resume();',
|
|
);
|
|
const { manager, sessionId } = await start(provider);
|
|
const status = manager.status(sessionId);
|
|
expect(status?.recent_output).toHaveLength(64);
|
|
expect(status?.recent_output_truncated).toBe(true);
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"returns partial unknown evidence when the process exits mid-command",
|
|
async () => {
|
|
const provider = await makeProvider(
|
|
'process.stdout.write("\\0"); process.stdin.setEncoding("utf8"); process.stdin.on("data", () => { process.stdout.write("partial\\0"); process.exit(0); });',
|
|
);
|
|
const { manager, sessionId } = await start(provider);
|
|
const result = await manager.execute(sessionId, "dr");
|
|
expect(result.ok).toBe(true);
|
|
if (result.ok) {
|
|
expect(result.value.result).toMatchObject({
|
|
output: "partial",
|
|
completion_status: "unknown",
|
|
});
|
|
expect(result.value.evidence.limitations.join(" ")).toContain(
|
|
"Rizin exited before",
|
|
);
|
|
}
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"cancels a command after sending it and stops its owned session",
|
|
async () => {
|
|
const provider = await makeProvider(
|
|
'process.stdout.write("\\0"); process.stdin.resume();',
|
|
);
|
|
const { manager, sessionId } = await start(provider);
|
|
const abort = new AbortController();
|
|
const execution = manager.execute(sessionId, "slow", abort.signal);
|
|
setTimeout(() => abort.abort(), 30);
|
|
expect((await execution).ok).toBe(false);
|
|
expect(manager.status(sessionId)?.state).toBe("closed");
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"preserves partial timeout evidence when cleanup cannot be confirmed",
|
|
async () => {
|
|
const provider = await makeProvider(
|
|
'process.stdout.write("\\0"); process.stdin.setEncoding("utf8"); process.stdin.on("data", (chunk) => { if (chunk.includes("slow")) process.stdout.write("partial\\0"); });',
|
|
);
|
|
const { manager, sessionId } = await start(provider, {
|
|
frameTimeoutMs: 25,
|
|
stopProcess: incompleteStop,
|
|
});
|
|
const result = await manager.execute(sessionId, "slow");
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok) {
|
|
expect(result.error.cleanupIncomplete).toBe(true);
|
|
expect(result.error.cleanupResources).toEqual([sessionId]);
|
|
const evidence = evidenceSchema.parse(result.error.partialObservation);
|
|
expect(evidence.normalized_result).toMatchObject({
|
|
completion_status: "unknown",
|
|
});
|
|
expect(evidence.limitations.join(" ")).toContain(
|
|
"injected stop uncertainty",
|
|
);
|
|
}
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"preserves truncated output when cleanup cannot be confirmed",
|
|
async () => {
|
|
const provider = await makeProvider(
|
|
`process.stdout.write("\\0");
|
|
let input = "";
|
|
process.stdin.setEncoding("utf8");
|
|
process.stdin.on("data", (chunk) => {
|
|
input += chunk;
|
|
for (;;) {
|
|
const end = input.indexOf("\\n");
|
|
if (end < 0) break;
|
|
const line = input.slice(0, end); input = input.slice(end + 1);
|
|
if (line === "many") process.stdout.write(Array.from({ length: 4100 }, (_, i) => "frame" + i + "\\0").join(""));
|
|
else if (line.startsWith("!echo ")) process.stdout.write(line.slice(6) + "\\0");
|
|
}
|
|
});`,
|
|
);
|
|
const { manager, sessionId } = await start(provider, {
|
|
frameTimeoutMs: 1000,
|
|
stopProcess: incompleteStop,
|
|
});
|
|
const result = await manager.execute(sessionId, "many");
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok) {
|
|
expect(result.error.cleanupIncomplete).toBe(true);
|
|
expect(result.error.cleanupResources).toEqual([sessionId]);
|
|
const evidence = evidenceSchema.parse(result.error.partialObservation);
|
|
expect(evidence.normalized_result).toMatchObject({
|
|
completion_status: "unknown",
|
|
});
|
|
expect(evidence.limitations.join(" ")).toContain(
|
|
"injected stop uncertainty",
|
|
);
|
|
}
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"preserves the cleanup uncertainty when cancellation cannot confirm process stop",
|
|
async () => {
|
|
const provider = await makeProvider(
|
|
'process.stdout.write("\\0"); process.stdin.resume();',
|
|
);
|
|
const { manager, sessionId } = await start(provider, {
|
|
stopProcess: incompleteStop,
|
|
});
|
|
const abort = new AbortController();
|
|
const execution = manager.execute(sessionId, "slow", abort.signal);
|
|
setTimeout(() => abort.abort(), 30);
|
|
const result = await execution;
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok)
|
|
expect(result.error.message).toContain("injected stop uncertainty");
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"cancels a queued command without sending it after the prior command completes",
|
|
async () => {
|
|
const provider = await makeProvider(
|
|
`process.stdout.write("\\0");
|
|
let input = "";
|
|
process.stdin.setEncoding("utf8");
|
|
process.stdin.on("data", (chunk) => {
|
|
input += chunk;
|
|
for (;;) {
|
|
const end = input.indexOf("\\n");
|
|
if (end < 0) break;
|
|
const line = input.slice(0, end); input = input.slice(end + 1);
|
|
if (line === "first") setTimeout(() => {}, 100);
|
|
else if (line.startsWith("!echo ")) setTimeout(() => process.stdout.write(line.slice(6) + "\\0"), 100);
|
|
}
|
|
});`,
|
|
);
|
|
const { manager, sessionId } = await start(provider, {
|
|
frameTimeoutMs: 300,
|
|
});
|
|
const first = manager.execute(sessionId, "first");
|
|
const abort = new AbortController();
|
|
const queued = manager.execute(sessionId, "second", abort.signal);
|
|
setTimeout(() => abort.abort(), 20);
|
|
expect((await queued).ok).toBe(false);
|
|
expect((await first).ok).toBe(true);
|
|
},
|
|
);
|