From 0156f641dd017e86bb5b22940e99e68786021f7a Mon Sep 17 00:00:00 2001 From: baldurk Date: Thu, 17 Dec 2015 12:57:37 +0100 Subject: [PATCH] Don't add wrappers while capturing - allows duplicate handles in capture * If we don't add objects into the real->wrapper map, then duplicate objects returned from the driver are fine. We will naturally create a unique handle for each and we don't have to worry about clashes, as the application will see each unique handle and free them separately since it's not allowed to *rely* on duplicate handles. Then when they destroy the unique handles, we'll end up destroying the duplicates multiple times. --- renderdoc/driver/vulkan/vk_manager.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/renderdoc/driver/vulkan/vk_manager.h b/renderdoc/driver/vulkan/vk_manager.h index f39ba70e7..458421eb0 100644 --- a/renderdoc/driver/vulkan/vk_manager.h +++ b/renderdoc/driver/vulkan/vk_manager.h @@ -140,7 +140,8 @@ class VulkanResourceManager : public ResourceManager