From 039ae9fa35ca27d0f41536b940f529356df197bc Mon Sep 17 00:00:00 2001 From: baldurk Date: Tue, 11 Nov 2025 13:43:24 +0000 Subject: [PATCH] Avoid crash if invalid internal image copy happens in pixel history --- renderdoc/driver/d3d12/d3d12_pixelhistory.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/renderdoc/driver/d3d12/d3d12_pixelhistory.cpp b/renderdoc/driver/d3d12/d3d12_pixelhistory.cpp index 4a13fa774..e2da7212e 100644 --- a/renderdoc/driver/d3d12/d3d12_pixelhistory.cpp +++ b/renderdoc/driver/d3d12/d3d12_pixelhistory.cpp @@ -686,6 +686,12 @@ protected: return; } + if(p.copyFormat == DXGI_FORMAT_UNKNOWN) + { + RDCERR("Ignoring invalid source image format", p.x, p.y, srcDesc.Width, srcDesc.Height); + return; + } + uint32_t baseMip = m_CallbackInfo.targetSubresource.mip; bool copy3d = m_CallbackInfo.targetDesc.Dimension == D3D12_RESOURCE_DIMENSION_TEXTURE3D; uint32_t baseSlice = m_CallbackInfo.targetSubresource.slice;