From 048b85ffc840b01fc398f032626868f4596d3d86 Mon Sep 17 00:00:00 2001 From: baldurk Date: Mon, 10 Oct 2022 16:50:13 +0100 Subject: [PATCH] Fix a problem copying stale reference when adding history modifications --- renderdoc/driver/vulkan/vk_pixelhistory.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/renderdoc/driver/vulkan/vk_pixelhistory.cpp b/renderdoc/driver/vulkan/vk_pixelhistory.cpp index 4b72cbec0..fd3ec2525 100644 --- a/renderdoc/driver/vulkan/vk_pixelhistory.cpp +++ b/renderdoc/driver/vulkan/vk_pixelhistory.cpp @@ -3947,9 +3947,13 @@ rdcarray VulkanReplay::PixelHistory(rdcarray even eventPremods[mod.eventId] = mod.preMod; } - for(int32_t f = 1; f < frags; f++) + if(frags > 1) { - history.insert(h + 1, mod); + PixelModification duplicate = mod; + for(int32_t f = 1; f < frags; f++) + { + history.insert(h + 1, duplicate); + } } for(int32_t f = 0; f < frags; f++) history[h + f].fragIndex = f;