From 07464f27ad44bf11a74a8b1283ba4ed10f00b67e Mon Sep 17 00:00:00 2001 From: baldurk Date: Sun, 5 Oct 2014 16:30:33 +0100 Subject: [PATCH] [Refs #87: Static Analysis] Add annotations from original definition --- renderdoc/os/win32/win32_shellext.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/renderdoc/os/win32/win32_shellext.cpp b/renderdoc/os/win32/win32_shellext.cpp index 3c4c53c66..e082d4c77 100644 --- a/renderdoc/os/win32/win32_shellext.cpp +++ b/renderdoc/os/win32/win32_shellext.cpp @@ -316,14 +316,17 @@ struct RDCThumbnailProviderFactory : public IClassFactory bool locked; }; -STDAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID *ppv) +_Check_return_ +STDAPI DllGetClassObject(_In_ REFCLSID rclsid, _In_ REFIID riid, _Outptr_ LPVOID* ppv) { if(rclsid == CLSID_RDCThumbnailProvider) { - *ppv = (LPVOID)(new RDCThumbnailProviderFactory); + if(ppv) *ppv = (LPVOID)(new RDCThumbnailProviderFactory); return S_OK; } + if(ppv) *ppv = NULL; + return CLASS_E_CLASSNOTAVAILABLE; }