From 07660287247943c853c8246c4c82c3fefb4c3440 Mon Sep 17 00:00:00 2001 From: baldurk Date: Tue, 2 Jul 2019 19:15:36 +0100 Subject: [PATCH] Change wording of non-core context GL overlay warning * Technically if you create a context with *CreateContextAttribsARB and don't specify a profile mask at all, the spec says the value of the profile bit is CORE_PROFILE_BIT. In practice this means drivers may or may not give you a core or compatibility profile. * However what we're really looking for here is the chance that the user code will use only modern GL or will use deprecated functionality, and in that case the high likelihood is if they omit the PROFILE_BIT entirely they are probably unaware of it, rather than letting it set its default value. --- renderdoc/driver/gl/gl_driver.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/renderdoc/driver/gl/gl_driver.cpp b/renderdoc/driver/gl/gl_driver.cpp index e4b695fd1..6b05cc13c 100644 --- a/renderdoc/driver/gl/gl_driver.cpp +++ b/renderdoc/driver/gl/gl_driver.cpp @@ -1762,7 +1762,9 @@ void WrappedOpenGL::SwapBuffers(void *windowHandle) } else if(!ctxdata.isCore) { - overlayText += "WARNING: Non-core context in use. Compatibility profile not supported.\n"; + overlayText += + "WARNING: Core profile not explicitly requested. Compatibility profile is not " + "supported.\n"; } if(activeWindow && m_FailedFrame > 0)