From 0991642393619c6fa9ed6fe4e5e031c12290e767 Mon Sep 17 00:00:00 2001 From: baldurk Date: Tue, 2 Jan 2018 16:34:14 +0000 Subject: [PATCH] Add error message in case reading from file fails while embedding --- renderdoccmd/renderdoccmd.cpp | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/renderdoccmd/renderdoccmd.cpp b/renderdoccmd/renderdoccmd.cpp index 05deea336..913b93754 100644 --- a/renderdoccmd/renderdoccmd.cpp +++ b/renderdoccmd/renderdoccmd.cpp @@ -1067,11 +1067,20 @@ struct EmbeddedSectionCommand : public Command bytebuf blob; fseek(f, 0, SEEK_END); - size_t len = (size_t)ftell(f); + int len = ftell(f); fseek(f, 0, SEEK_SET); - blob.resize(len); - fread(blob.data(), 1, len, f); + if(len < 0) + { + len = 0; + std::cerr << "I/O error reading from '" << file << "'" << std::endl; + } + + blob.resize((size_t)len); + size_t read = fread(blob.data(), 1, (size_t)len, f); + + if(read != (size_t)len) + std::cerr << "I/O error reading from '" << file << "'" << std::endl; fclose(f);