lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-08 07:41:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve poorly written Android install failure messages. Closes #1459

Browse Source 
* We also add a new message specifically for when the install succeeds but we
  can't verify it, to indicate the problem better than suggesting that
  permission errors are at fault.
This commit is contained in:
baldurk
2019-07-22 14:52:42 +01:00
parent 93fbb5e300
commit 09df7a12c6
3 changed files with 44 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Windows/MainWindow.cpp
+20 -13
View File
@@ -2878,31 +2878,38 @@ bool MainWindow::LoadLayout(int layout)
void MainWindow::showLaunchError(ReplayStatus status)
{
QString title;
QString message;
switch(status)
{
case ReplayStatus::AndroidGrantPermissionsFailed:
title = tr("Permission is required");
message = tr("Enable RenderDocCmd to access storage on your device.");
message =
tr("Failed to automatically grant Android permissions to installed server.\n\n"
"Please manually allow the RenderDocCmd program storage permissions on your device "
"to ensure correct functionality.");
break;
case ReplayStatus::AndroidABINotFound:
title = tr("Failed to install RenderDoc server");
message = tr("Couldn't determine supported ABIs.");
message =
tr("Couldn't determine supported ABIs for your device, please check device connection "
"and status.");
break;
case ReplayStatus::AndroidAPKFolderNotFound:
title = tr("Failed to install RenderDoc server");
message = tr("APK folder missing.");
message = tr("Couldn't find APK folder, please check that your installation is complete.");
break;
case ReplayStatus::AndroidAPKInstallFailed:
title = tr("Failed to install RenderDoc server");
message = tr("Couldn't find any installed APKs.");
default:
title = tr("Failed to install RenderDoc server");
message = tr("Unknown error.");
message =
tr("Couldn't install APK, please check that your device is connected and accessible to "
"adb.");
case ReplayStatus::AndroidAPKVerifyFailed:
message =
tr("Couldn't correctly verify installed APK version.\n\n"
"Please check your installation is not corrupted, or if this is a custom build check "
"that all ABIs are built at the same version as this program.");
break;
default: message = tr("Unexpected error: %1.").arg(ToQStr(status)); break;
}
GUIInvoke::call(this, [this, title, message]() { RDDialog::warning(this, title, message); });
GUIInvoke::call(this, [this, message]() {
RDDialog::warning(this, tr("Problems installing RenderDoc server"), message);
});
}
bool MainWindow::isCapturableAppRunningOnAndroid()