lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-09-26 23:55:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Coverity: When possible, pass big params by const ref instead of by val

Browse Source
This commit is contained in:
baldurk
2016-06-09 13:56:52 -07:00
parent d5b04583dd
commit 0afc7ea6c3
22 changed files with 121 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/replay/replay_driver.h
+4 -4
View File
@@ -148,15 +148,15 @@ public:
float minval, float maxval, bool channels[4],
vector<uint32_t> &histogram) = 0;
virtual ResourceId CreateProxyTexture(FetchTexture templateTex) = 0;
virtual ResourceId CreateProxyTexture(const FetchTexture &templateTex) = 0;
virtual void SetProxyTextureData(ResourceId texid, uint32_t arrayIdx, uint32_t mip, byte *data,
size_t dataSize) = 0;
virtual ResourceId CreateProxyBuffer(FetchBuffer templateBuf) = 0;
virtual ResourceId CreateProxyBuffer(const FetchBuffer &templateBuf) = 0;
virtual void SetProxyBufferData(ResourceId bufid, byte *data, size_t dataSize) = 0;
virtual void RenderMesh(uint32_t eventID, const vector<MeshFormat> &secondaryDraws,
MeshDisplay cfg) = 0;
const MeshDisplay &cfg) = 0;
virtual bool RenderTexture(TextureDisplay cfg) = 0;
virtual void BuildCustomShader(string source, string entry, const uint32_t compileFlags,
@@ -170,7 +170,7 @@ public:
virtual void PickPixel(ResourceId texture, uint32_t x, uint32_t y, uint32_t sliceFace,
uint32_t mip, uint32_t sample, float pixel[4]) = 0;
virtual uint32_t PickVertex(uint32_t eventID, MeshDisplay cfg, uint32_t x, uint32_t y) = 0;
virtual uint32_t PickVertex(uint32_t eventID, const MeshDisplay &cfg, uint32_t x, uint32_t y) = 0;
};
// utility function useful in any driver implementation