lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-06 10:00:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use rdc types instead of Qt containers in public QRenderDoc interface

Browse Source 
* This is to support python bindings - the pyside implementation of
  QVector, QString, etc is not available to SWIG, so SWIG treates these
  all as opaque types.
* Rather than trying to set up bindings that work for rdcarray and
  QList/QVector, or implementing separate bindings, we instead just say
  that the public interface must use the rdc types. In most cases they
  seamlessly convert to/from Qt types anyway.
* In a couple of places we use an array of pairs instead of a map. In
  future we probably want an rdcdict or rdcmap with proper dict bindings
  in python.
This commit is contained in:
baldurk
2017-12-13 16:40:44 +00:00
parent d081623181
commit 0b527fab49
43 changed files with 754 additions and 559 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Windows/CommentView.cpp
+2 -2
View File
@@ -77,7 +77,7 @@ void CommentView::OnCaptureClosed()
void CommentView::OnCaptureLoaded()
{
m_commentsEditor->setText(m_Ctx.GetNotes(lit("comments")).toUtf8().data());
m_commentsEditor->setText(m_Ctx.GetNotes("comments").c_str());
m_commentsEditor->emptyUndoBuffer();
m_ignoreModifications = false;
}
@@ -85,7 +85,7 @@ void CommentView::OnCaptureLoaded()
void CommentView::OnEventChanged(uint32_t eventID)
{
QString oldText = QString::fromUtf8(m_commentsEditor->getText(m_commentsEditor->textLength() + 1));
QString newText = m_Ctx.GetNotes(lit("comments"));
QString newText = m_Ctx.GetNotes("comments");
if(oldText != newText)
{