From 0e86f0e3209723bff835930dae6e9390285c2f9b Mon Sep 17 00:00:00 2001 From: baldurk Date: Mon, 15 Feb 2021 10:43:06 +0000 Subject: [PATCH] Fix overflow setting rowOffset when numRows is 0 --- qrenderdoc/Windows/BufferViewer.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qrenderdoc/Windows/BufferViewer.cpp b/qrenderdoc/Windows/BufferViewer.cpp index 999e48291..3e2241904 100644 --- a/qrenderdoc/Windows/BufferViewer.cpp +++ b/qrenderdoc/Windows/BufferViewer.cpp @@ -2680,11 +2680,11 @@ void BufferViewer::OnEventChanged(uint32_t eventId) if(!m_MeshView) numRows = qMax(numRows, bufdata->vsinConfig.unclampedNumRows); - ui->rowOffset->setMaximum((int)qMax(0U, numRows - 1)); + ui->rowOffset->setMaximum((int)qMax(1U, numRows) - 1); - ScrollToRow(ui->vsinData, qMin(int(bufdata->vsinConfig.numRows - 1), bufdata->vsinVert)); - ScrollToRow(ui->vsoutData, qMin(int(bufdata->vsoutConfig.numRows - 1), bufdata->vsoutVert)); - ScrollToRow(ui->gsoutData, qMin(int(bufdata->gsoutConfig.numRows - 1), bufdata->gsoutVert)); + ScrollToRow(ui->vsinData, qMin(int(bufdata->vsinConfig.numRows) - 1, bufdata->vsinVert)); + ScrollToRow(ui->vsoutData, qMin(int(bufdata->vsoutConfig.numRows) - 1, bufdata->vsoutVert)); + ScrollToRow(ui->gsoutData, qMin(int(bufdata->gsoutConfig.numRows) - 1, bufdata->gsoutVert)); ui->vsinData->horizontalScrollBar()->setValue(bufdata->vsinHoriz); ui->vsoutData->horizontalScrollBar()->setValue(bufdata->vsoutHoriz);