From 0ecc8ed0e5c0fbb82f8e95b72e99804136e56754 Mon Sep 17 00:00:00 2001 From: baldurk Date: Wed, 4 Apr 2018 17:53:28 +0100 Subject: [PATCH] Fix a reported NULL pointer dereference when exporting GL state to HTML --- qrenderdoc/Windows/PipelineState/GLPipelineStateViewer.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/qrenderdoc/Windows/PipelineState/GLPipelineStateViewer.cpp b/qrenderdoc/Windows/PipelineState/GLPipelineStateViewer.cpp index 5383fd3a2..d2d13d929 100644 --- a/qrenderdoc/Windows/PipelineState/GLPipelineStateViewer.cpp +++ b/qrenderdoc/Windows/PipelineState/GLPipelineStateViewer.cpp @@ -2637,15 +2637,12 @@ void GLPipelineStateViewer::exportHTML(QXmlStreamWriter &xml, const GLPipe::Shad uint64_t byteSize = shaderCBuf.byteSize; QString slotname = tr("Uniforms"); - QString name = m_Ctx.GetResourceName(b->resourceId); + QString name = tr("Empty"); QString sizestr = tr("%1 Variables").arg(numvars); QString byterange; if(!filledSlot) - { - name = tr("Empty"); length = 0; - } if(b) { @@ -2653,6 +2650,8 @@ void GLPipelineStateViewer::exportHTML(QXmlStreamWriter &xml, const GLPipe::Shad offset = b->byteOffset; length = b->byteSize; + name = m_Ctx.GetResourceName(b->resourceId); + BufferDescription *buf = m_Ctx.GetBuffer(b->resourceId); if(buf && length == 0) length = buf->length;