lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-29 21:30:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Never clamp to an invalid index even for invalid inputs

Browse Source 
* This prevents a crash as at least index 0 is always a valid scalar lookup.
This commit is contained in:
baldurk
2020-09-01 16:39:19 +01:00
parent 83f7a26ee9
commit 10878bb5a9
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/shaders/spirv/spirv_debug_setup.cpp
+3 -3
View File
@@ -45,7 +45,7 @@ static void ClampScalars(rdcspv::DebugAPIWrapper *apiWrapper, const ShaderVariab
MessageCategory::Execution, MessageSeverity::High, MessageSource::RuntimeWarning,
StringFormat::Fmt("Invalid scalar index %u at %u-vector %s. Clamping to %u", scalar0,
var.columns, var.name.c_str(), var.columns - 1));
scalar0 = var.columns - 1;
scalar0 = RDCMIN(0U, uint32_t(var.columns - 1));
}
}
@@ -58,7 +58,7 @@ static void ClampScalars(rdcspv::DebugAPIWrapper *apiWrapper, const ShaderVariab
MessageCategory::Execution, MessageSeverity::High, MessageSource::RuntimeWarning,
StringFormat::Fmt("Invalid scalar index %u at matrix %s with %u columns. Clamping to %u",
scalar0, var.columns, var.name.c_str(), var.columns - 1));
scalar0 = var.columns - 1;
scalar0 = RDCMIN(0U, uint32_t(var.columns - 1));
}
if(scalar1 > var.rows && scalar1 != ~0U)
{
@@ -66,7 +66,7 @@ static void ClampScalars(rdcspv::DebugAPIWrapper *apiWrapper, const ShaderVariab
MessageCategory::Execution, MessageSeverity::High, MessageSource::RuntimeWarning,
StringFormat::Fmt("Invalid scalar index %u at matrix %s with %u rows. Clamping to %u",
scalar1, var.rows, var.name.c_str(), var.rows - 1));
scalar1 = var.rows - 1;
scalar1 = RDCMIN(0U, uint32_t(var.rows - 1));
}
}