From 1301d9041800066f4428341fe91d1b4597a8e7f2 Mon Sep 17 00:00:00 2001
From: Jake Turner <jake@evansturner.co.uk>
Date: Mon, 24 Jul 2023 07:19:05 +0100
Subject: [PATCH] GL Pixel History small code clean up in
 CalculateFragmentDepthTests

Move constant out of inner loop.
Remove if test for depth test being enabled and set the depth function to GL_ALWAYS if the depth test is disabled.
---
 renderdoc/driver/gl/gl_pixelhistory.cpp | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/renderdoc/driver/gl/gl_pixelhistory.cpp b/renderdoc/driver/gl/gl_pixelhistory.cpp
index 930652cb4..515608be3 100644
--- a/renderdoc/driver/gl/gl_pixelhistory.cpp
+++ b/renderdoc/driver/gl/gl_pixelhistory.cpp
@@ -2035,6 +2035,11 @@ void CalculateFragmentDepthTests(WrappedOpenGL *driver, GLPixelHistoryResources
       continue;
     }
 
+    GLboolean depthTestEnabled = driver->glIsEnabled(eGL_DEPTH_TEST);
+    // default for no depth test
+    int depthFunc = eGL_ALWAYS;
+    if(depthTestEnabled)
+      driver->glGetIntegerv(eGL_DEPTH_FUNC, &depthFunc);
     for(; historyIndex < history.size() && modEvents[i].eventId == history[historyIndex].eventId;
         ++historyIndex)
     {
@@ -2043,19 +2048,8 @@ void CalculateFragmentDepthTests(WrappedOpenGL *driver, GLPixelHistoryResources
         continue;
       }
 
-      if(driver->glIsEnabled(eGL_DEPTH_TEST))
-      {
-        int depthFunc;
-        driver->glGetIntegerv(eGL_DEPTH_FUNC, &depthFunc);
-
-        history[historyIndex].depthTestFailed = !depthTestPassed(
-            depthFunc, history[historyIndex].shaderOut.depth, history[historyIndex].preMod.depth);
-      }
-      else
-      {
-        // since there is no depth test, there is no failure.
-        history[historyIndex].depthTestFailed = false;
-      }
+      history[historyIndex].depthTestFailed = !depthTestPassed(
+          depthFunc, history[historyIndex].shaderOut.depth, history[historyIndex].preMod.depth);
     }
 
     if(i < modEvents.size() - 1)