From 170f29ebfa623188bce530c51b82d0b701f7c99a Mon Sep 17 00:00:00 2001 From: baldurk Date: Fri, 4 Dec 2020 10:42:10 +0000 Subject: [PATCH] Disable loading LunarG validation layer * Previously we hinted loading both the old LunarG metalayer and the new combined Khronos layer. Since only one was a 'real' layer this was safe and would allow us to enable validation anywhere without needing to enumerate available layers. * Unfortunately a new loader version makes it an error to specify the VK_LAYER_LUNARG_standard_validation for loading! So it is completely impossible to be fully compatible. We have no choice then but to follow the loader/SDK's path and have a hard backwards compatibility break. * This means the validation won't be enabled anymore for anyone on SDK from early 2019 and before. --- renderdoc/driver/vulkan/vk_layer.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/renderdoc/driver/vulkan/vk_layer.cpp b/renderdoc/driver/vulkan/vk_layer.cpp index e8374098a..1f865d2b9 100644 --- a/renderdoc/driver/vulkan/vk_layer.cpp +++ b/renderdoc/driver/vulkan/vk_layer.cpp @@ -142,12 +142,6 @@ class VulkanHook : LibraryHook { if(RenderDoc::Inst().GetCaptureOptions().apiValidation) { - Process::RegisterEnvironmentModification( - EnvironmentModification(EnvMod::Append, EnvSep::Platform, "VK_INSTANCE_LAYERS", - "VK_LAYER_LUNARG_standard_validation")); - Process::RegisterEnvironmentModification( - EnvironmentModification(EnvMod::Append, EnvSep::Platform, "VK_DEVICE_LAYERS", - "VK_LAYER_LUNARG_standard_validation")); Process::RegisterEnvironmentModification(EnvironmentModification( EnvMod::Append, EnvSep::Platform, "VK_INSTANCE_LAYERS", "VK_LAYER_KHRONOS_validation")); Process::RegisterEnvironmentModification(EnvironmentModification(