From 1816bb809ba0aa70fdfa2d87baa6f7e54150761e Mon Sep 17 00:00:00 2001 From: Jake Turner Date: Wed, 29 Jun 2022 14:51:40 +0100 Subject: [PATCH] Use capture mode directly : don't use local var ie. replace bool backframe = IsBackgroundCapturing(m_State); if(backframe) with if(IsBackgroundCapturing(m_State)) --- renderdoc/driver/metal/metal_buffer.cpp | 7 ++----- renderdoc/driver/metal/metal_command_buffer.cpp | 3 +-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/renderdoc/driver/metal/metal_buffer.cpp b/renderdoc/driver/metal/metal_buffer.cpp index d8504af34..2b6203159 100644 --- a/renderdoc/driver/metal/metal_buffer.cpp +++ b/renderdoc/driver/metal/metal_buffer.cpp @@ -86,15 +86,12 @@ void WrappedMTLBuffer::didModifyRange(NS::Range &range) SERIALISE_TIME_CALL(Unwrap(this)->didModifyRange(range)); if(IsCaptureMode(m_State)) { - bool backframe = IsBackgroundCapturing(m_State); - if(backframe) + if(IsBackgroundCapturing(m_State)) { // Snapshot potentially CPU modified buffer GetResourceManager()->MarkDirtyResource(m_ID); } - - bool capframe = IsActiveCapturing(m_State); - if(capframe) + else { Chunk *chunk = NULL; { diff --git a/renderdoc/driver/metal/metal_command_buffer.cpp b/renderdoc/driver/metal/metal_command_buffer.cpp index 2caaf2a42..488fe7233 100644 --- a/renderdoc/driver/metal/metal_command_buffer.cpp +++ b/renderdoc/driver/metal/metal_command_buffer.cpp @@ -219,8 +219,7 @@ void WrappedMTLCommandBuffer::commit() MetalResourceRecord *bufferRecord = GetRecord(this); bufferRecord->AddChunk(chunk); - bool capframe = IsActiveCapturing(m_State); - if(capframe) + if(IsActiveCapturing(m_State)) { bufferRecord->AddRef(); bufferRecord->MarkResourceFrameReferenced(GetResID(m_CommandQueue), eFrameRef_Read);