From 24564a54393368da2e44046408b2b798d5f559d8 Mon Sep 17 00:00:00 2001
From: baldurk <baldurk@baldurk.org>
Date: Tue, 7 Feb 2017 15:14:55 +0000
Subject: [PATCH] Don't pass strings by copy unnecessarily

---
 qrenderdoc/Code/PersistantConfig.cpp | 7 +++++--
 qrenderdoc/Code/PersistantConfig.h   | 4 ++--
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/qrenderdoc/Code/PersistantConfig.cpp b/qrenderdoc/Code/PersistantConfig.cpp
index 96f726b79..94756d1ec 100644
--- a/qrenderdoc/Code/PersistantConfig.cpp
+++ b/qrenderdoc/Code/PersistantConfig.cpp
@@ -288,13 +288,16 @@ void PersistantConfig::AddRecentFile(QList<QString> &recentList, const QString &
   }
 }
 
-void PersistantConfig::SetConfigSetting(QString name, QString value)
+void PersistantConfig::SetConfigSetting(const QString &name, const QString &value)
 {
+  if(name.isEmpty())
+    return;
+
   ConfigSettings[name] = value;
   RENDERDOC_SetConfigSetting(name.toUtf8().data(), value.toUtf8().data());
 }
 
-QString PersistantConfig::GetConfigSetting(QString name)
+QString PersistantConfig::GetConfigSetting(const QString &name)
 {
   if(ConfigSettings.contains(name))
     return ConfigSettings[name];
diff --git a/qrenderdoc/Code/PersistantConfig.h b/qrenderdoc/Code/PersistantConfig.h
index 24c002332..7de4b4f3c 100644
--- a/qrenderdoc/Code/PersistantConfig.h
+++ b/qrenderdoc/Code/PersistantConfig.h
@@ -155,8 +155,8 @@ public:
 
   static void AddRecentFile(QList<QString> &recentList, const QString &file, int maxItems);
 
-  void SetConfigSetting(QString name, QString value);
-  QString GetConfigSetting(QString name);
+  void SetConfigSetting(const QString &name, const QString &value);
+  QString GetConfigSetting(const QString &name);
 
 private:
   bool Deserialize(const QString &filename);