From 25465cb2479d0f7887c422629fe4810fa7bc8f0d Mon Sep 17 00:00:00 2001 From: baldurk Date: Wed, 14 Sep 2016 17:53:54 +0200 Subject: [PATCH] [Coverity] Fix some uninitialised values --- renderdoc/core/replay_proxy.cpp | 6 +++--- renderdoc/core/replay_proxy.h | 2 ++ renderdoc/core/target_control.cpp | 4 ++-- renderdoc/driver/d3d11/d3d11_debug.cpp | 2 ++ 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/renderdoc/core/replay_proxy.cpp b/renderdoc/core/replay_proxy.cpp index 86154828b..671506c9b 100644 --- a/renderdoc/core/replay_proxy.cpp +++ b/renderdoc/core/replay_proxy.cpp @@ -1943,7 +1943,7 @@ vector ReplayProxy::GetDebugMessages() FetchTexture ReplayProxy::GetTexture(ResourceId id) { - FetchTexture ret; + FetchTexture ret = {}; m_ToReplaySerialiser->Serialise("", id); @@ -1983,7 +1983,7 @@ vector ReplayProxy::GetBuffers() FetchBuffer ReplayProxy::GetBuffer(ResourceId id) { - FetchBuffer ret; + FetchBuffer ret = {}; m_ToReplaySerialiser->Serialise("", id); @@ -2373,7 +2373,7 @@ void ReplayProxy::InitPostVSBuffers(const vector &events) MeshFormat ReplayProxy::GetPostVSBuffers(uint32_t eventID, uint32_t instID, MeshDataStage stage) { - MeshFormat ret; + MeshFormat ret = {}; m_ToReplaySerialiser->Serialise("", eventID); m_ToReplaySerialiser->Serialise("", instID); diff --git a/renderdoc/core/replay_proxy.h b/renderdoc/core/replay_proxy.h index 382b1ea67..1f0c887ad 100644 --- a/renderdoc/core/replay_proxy.h +++ b/renderdoc/core/replay_proxy.h @@ -112,6 +112,8 @@ public: m_ToReplaySerialiser = NULL; m_FromReplaySerialiser = new Serialiser(NULL, Serialiser::WRITING, false); m_RemoteHasResolver = false; + + RDCEraseEl(m_APIProps); } virtual ~ReplayProxy(); diff --git a/renderdoc/core/target_control.cpp b/renderdoc/core/target_control.cpp index e8f5bfd48..cee4366c8 100644 --- a/renderdoc/core/target_control.cpp +++ b/renderdoc/core/target_control.cpp @@ -376,6 +376,8 @@ public: PacketType type; vector payload; + m_PID = 0; + { Serialiser ser("", Serialiser::WRITING, false); @@ -392,8 +394,6 @@ public: Serialiser *ser = NULL; GetPacket(type, ser); - m_PID = 0; - // failed handshaking if(m_Socket == NULL || ser == NULL) return; diff --git a/renderdoc/driver/d3d11/d3d11_debug.cpp b/renderdoc/driver/d3d11/d3d11_debug.cpp index b05351e8f..e02383cf8 100644 --- a/renderdoc/driver/d3d11/d3d11_debug.cpp +++ b/renderdoc/driver/d3d11/d3d11_debug.cpp @@ -93,6 +93,8 @@ D3D11DebugManager::D3D11DebugManager(WrappedID3D11Device *wrapper) m_supersamplingX = 1.0f; m_supersamplingY = 1.0f; + m_width = m_height = 1; + m_WrappedDevice = wrapper; ID3D11DeviceContext *ctx = NULL; m_WrappedDevice->GetImmediateContext(&ctx);