From 2b7bcccbc682b477c59281381522da7099fe4d66 Mon Sep 17 00:00:00 2001 From: baldurk Date: Wed, 26 Jun 2019 11:29:18 +0100 Subject: [PATCH] Don't continue with vulkan postvs fetch if PSO fails to compile * MoltenVK sometimes has problems with shader translation so we want to handle this gracefully if possible. --- renderdoc/driver/vulkan/vk_postvs.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/renderdoc/driver/vulkan/vk_postvs.cpp b/renderdoc/driver/vulkan/vk_postvs.cpp index be3b80837..dd9eba4c7 100644 --- a/renderdoc/driver/vulkan/vk_postvs.cpp +++ b/renderdoc/driver/vulkan/vk_postvs.cpp @@ -2263,7 +2263,12 @@ void VulkanReplay::FetchVSOut(uint32_t eventId) // create new pipeline VkPipeline pipe; vkr = m_pDriver->vkCreateComputePipelines(m_Device, VK_NULL_HANDLE, 1, &compPipeInfo, NULL, &pipe); - RDCASSERTEQUAL(vkr, VK_SUCCESS); + + if(vkr != VK_SUCCESS) + { + RDCERR("Failed to create patched compute pipeline: %s", ToStr(vkr).c_str()); + return; + } // make copy of state to draw from VulkanRenderState modifiedstate = state;