From 2f6dc6345818b0eb4ac75875758ec93963a16eac Mon Sep 17 00:00:00 2001 From: baldurk Date: Tue, 12 Nov 2019 08:57:31 +0000 Subject: [PATCH] Disable crash handler when chrome or chrome derivative is detected * The volume of invalid crash reports from people injecting into these programs is massive, and some filtering has to happen. --- renderdoc/core/core.cpp | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/renderdoc/core/core.cpp b/renderdoc/core/core.cpp index f510804d6..326bc9a29 100644 --- a/renderdoc/core/core.cpp +++ b/renderdoc/core/core.cpp @@ -239,6 +239,30 @@ RenderDoc &RenderDoc::Inst() void RenderDoc::RecreateCrashHandler() { #if ENABLED(RDOC_CRASH_HANDLER) + +#if ENABLED(RDOC_WIN32) + // there are way too many invalid reports coming from chrome, completely disable the crash handler + // in that case. + std::string exename; + FileIO::GetExecutableFilename(exename); + exename = strlower(exename); + + if(exename.find("chrome.exe") && + (GetModuleHandleA("chrome_elf.dll") || GetModuleHandleA("chrome_child.dll"))) + { + RDCWARN("Disabling crash handling server due to detected chrome."); + return; + } + + // some people use vivaldi which is just chrome + if(exename.find("vivaldi.exe") && + (GetModuleHandleA("vivaldi_elf.dll") || GetModuleHandleA("vivaldi_child.dll"))) + { + RDCWARN("Disabling crash handling server due to detected chrome."); + return; + } +#endif + m_ExHandler = new CrashHandler(m_ExHandler); #endif