lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-09-26 07:35:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix GL reflection unit tests

Browse Source 
* GL no longer reflects out fixed bindings and relies purely on queried
  uniforms.
This commit is contained in:
baldurk
2024-04-10 21:28:48 +01:00
parent b7f2e8a178
commit 2f9f3cd6a0
2 changed files with 84 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/shaders/spirv/spirv_reflect.cpp
+12 -9
View File
@@ -1362,16 +1362,19 @@ void Reflector::MakeReflection(const GraphicsAPI sourceAPI, const ShaderStage st
// On GL if we have a location and no binding, put that in as the bind. It is not used
// otherwise on GL as the bindings are dynamic. This should only happen for
// bare uniforms and not for texture/buffer type uniforms which should have a binding
if(sourceAPI == GraphicsAPI::OpenGL &&
(decorations[global.id].flags & (Decorations::HasLocation | Decorations::HasBinding)) ==
Decorations::HasLocation)
if(sourceAPI == GraphicsAPI::OpenGL)
{
bind = decorations[global.id].location;
}
else if(sourceAPI == GraphicsAPI::OpenGL &&
(decorations[global.id].flags & Decorations::HasLocation) == Decorations::NoFlags)
{
bind = ~0U;
Decorations::Flags flags = Decorations::Flags(
decorations[global.id].flags & (Decorations::HasLocation | Decorations::HasBinding));
if(flags == Decorations::HasLocation)
{
bind = decorations[global.id].location;
}
else if(flags == Decorations::NoFlags)
{
bind = ~0U;
}
}
if(usedIds.find(global.id) == usedIds.end())