From 31a06effb61084fbb49db12a67bf1229d5fbb5af Mon Sep 17 00:00:00 2001 From: baldurk Date: Wed, 14 Sep 2016 17:39:26 +0200 Subject: [PATCH] [Coverity] File closing was inconsistent between success/error paths --- renderdoc/core/image_viewer.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/renderdoc/core/image_viewer.cpp b/renderdoc/core/image_viewer.cpp index b361da2dc..04cb9e80c 100644 --- a/renderdoc/core/image_viewer.cpp +++ b/renderdoc/core/image_viewer.cpp @@ -457,8 +457,6 @@ void ImageViewer::RefreshFile() FileIO::fread(&buffer[0], 1, buffer.size(), f); - FileIO::fclose(f); - EXRImage exrImage; InitEXRImage(&exrImage); @@ -471,6 +469,7 @@ void ImageViewer::RefreshFile() RDCERR( "EXR file detected, but couldn't load with ParseMultiChannelEXRHeaderFromMemory %d: '%s'", ret, err); + FileIO::fclose(f); return; } @@ -520,6 +519,7 @@ void ImageViewer::RefreshFile() { free(data); RDCERR("EXR file detected, but couldn't load with LoadEXRFromMemory %d: '%s'", ret, err); + FileIO::fclose(f); return; } }