lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-09-22 21:55:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Coverity] Add some handling for return values in UI code

Browse Source
This commit is contained in:
baldurk
2018-05-08 12:32:56 +01:00
parent 1a5b189441
commit 42979bfeb3
3 changed files with 56 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Windows/Dialogs/CrashDialog.cpp
+25 -14
View File
@@ -331,15 +331,18 @@ void CrashDialog::sendReport()
QHttpPart capture;
QFile *file = new QFile(m_CaptureFilename);
file->open(QIODevice::ReadOnly);
file->setParent(multiPart);
if(file->open(QIODevice::ReadOnly))
{
file->setParent(multiPart);
capture.setHeader(QNetworkRequest::ContentTypeHeader, lit("application/x-renderdoc-capture"));
capture.setHeader(QNetworkRequest::ContentDispositionHeader,
lit("form-data; name=\"capture\"; filename=\"capture.rdc\""));
capture.setBodyDevice(file);
capture.setHeader(QNetworkRequest::ContentTypeHeader,
lit("application/x-renderdoc-capture"));
capture.setHeader(QNetworkRequest::ContentDispositionHeader,
lit("form-data; name=\"capture\"; filename=\"capture.rdc\""));
capture.setBodyDevice(file);
multiPart->append(capture);
multiPart->append(capture);
}
}
if(m_Thumbnail)
@@ -363,15 +366,23 @@ void CrashDialog::sendReport()
QHttpPart report;
QFile *file = new QFile(m_ReportPath);
file->open(QIODevice::ReadOnly);
file->setParent(multiPart);
if(file->open(QIODevice::ReadOnly))
{
file->setParent(multiPart);
report.setHeader(QNetworkRequest::ContentTypeHeader, lit("application/zip"));
report.setHeader(QNetworkRequest::ContentDispositionHeader,
lit("form-data; name=\"report\"; filename=\"report.zip\""));
report.setBodyDevice(file);
report.setHeader(QNetworkRequest::ContentTypeHeader, lit("application/zip"));
report.setHeader(QNetworkRequest::ContentDispositionHeader,
lit("form-data; name=\"report\"; filename=\"report.zip\""));
report.setBodyDevice(file);
multiPart->append(report);
multiPart->append(report);
}
else
{
ui->progressText->setText(tr("Error preparing crash report"));
// can't send report without report.zip
return;
}
}
QNetworkRequest request(QUrl(lit(BUGREPORT_URL)));