lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-26 08:26:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

ShaderVariable UI consistency check for duplicated variable change

Browse Source 
Detect if a ShaderVariable has multiple changes per step
This commit is contained in:
Jake Turner
2025-05-14 16:28:37 +01:00
parent b53bd38828
commit 47c64f607d
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Windows/ShaderViewer.cpp
+18
View File
@@ -2636,9 +2636,18 @@ void ShaderViewer::applyBackwardsChange()
if(IsFirstState())
return;
#if SHADER_VARIABLE_CHANGE_CONSISTENCY_CHECKS
QSet<rdcstr> changedVariables;
#endif // #if SHADER_VARIABLE_CHANGE_CONSISTENCY_CHECKS
const ShaderVariable nullChange;
for(const ShaderVariableChange &c : GetCurrentState().changes)
{
#if SHADER_VARIABLE_CHANGE_CONSISTENCY_CHECKS
rdcstr varName = c.before.name.empty() ? c.after.name : c.before.name;
if(changedVariables.contains(varName))
qCritical("Multiple ShaderVariableChange's for '%s'", varName.c_str());
changedVariables.insert(varName);
#endif // #if SHADER_VARIABLE_CHANGE_CONSISTENCY_CHECKS
// if the before name is empty, this is a variable that came into scope/was created
if(c.before.name.empty())
{
@@ -2711,9 +2720,18 @@ void ShaderViewer::applyForwardsChange()
rdcarray<AccessedResourceData> newAccessedResources;
#if SHADER_VARIABLE_CHANGE_CONSISTENCY_CHECKS
QSet<rdcstr> changedVariables;
#endif // #if SHADER_VARIABLE_CHANGE_CONSISTENCY_CHECKS
const ShaderVariable nullChange;
for(const ShaderVariableChange &c : GetCurrentState().changes)
{
#if SHADER_VARIABLE_CHANGE_CONSISTENCY_CHECKS
rdcstr varName = c.after.name.empty() ? c.before.name : c.after.name;
if(changedVariables.contains(varName))
qCritical("Multiple ShaderVariableChange's for '%s'", varName.c_str());
changedVariables.insert(varName);
#endif // #if SHADER_VARIABLE_CHANGE_CONSISTENCY_CHECKS
// if the after name is empty, this is a variable going out of scope/being deleted
if(c.after.name.empty())
{