From 482f337cf1c176f8e7c05d933bdc5f1a430b08d4 Mon Sep 17 00:00:00 2001 From: baldurk Date: Tue, 2 Feb 2016 22:14:38 +0100 Subject: [PATCH] Re-enabled memcmp'ing of coherent maps on queue submit --- renderdoc/driver/vulkan/wrappers/vk_queue_funcs.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/renderdoc/driver/vulkan/wrappers/vk_queue_funcs.cpp b/renderdoc/driver/vulkan/wrappers/vk_queue_funcs.cpp index b42908491..e2080c18d 100644 --- a/renderdoc/driver/vulkan/wrappers/vk_queue_funcs.cpp +++ b/renderdoc/driver/vulkan/wrappers/vk_queue_funcs.cpp @@ -573,8 +573,10 @@ VkResult WrappedVulkan::vkQueueSubmit( size_t diffStart = 0, diffEnd = 0; bool found = true; - // disable for now as there seem to be bugs. -#if 0 + // enabled as this is necessary for programs with very large coherent mappings + // (> 1GB) as otherwise more than a couple of vkQueueSubmit calls leads to vast + // memory allocation. There might still be bugs lurking in here though +#if 1 // this causes vkFlushMappedMemoryRanges call to allocate and copy to refData // from serialised buffer. We want to copy *precisely* the serialised data, // otherwise there is a gap in time between serialising out a snapshot of