From 4992e09918de784af160b97c197c4de5fc53f93c Mon Sep 17 00:00:00 2001 From: Baldur Karlsson Date: Mon, 12 Mar 2018 15:40:44 +0000 Subject: [PATCH] Fix potential crash if shader reflection is NULL --- renderdoc/driver/gl/gl_shader_refl.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/renderdoc/driver/gl/gl_shader_refl.cpp b/renderdoc/driver/gl/gl_shader_refl.cpp index d822de364..e2e6537dd 100644 --- a/renderdoc/driver/gl/gl_shader_refl.cpp +++ b/renderdoc/driver/gl/gl_shader_refl.cpp @@ -1913,6 +1913,12 @@ void MakeShaderReflection(const GLHookSet &gl, GLenum shadType, GLuint sepProg, void GetBindpointMapping(const GLHookSet &gl, GLuint curProg, int shadIdx, ShaderReflection *refl, ShaderBindpointMapping &mapping) { + if(!refl) + { + mapping = ShaderBindpointMapping(); + return; + } + // in case of bugs, we readback into this array instead of GLint dummyReadback[32];