From 50ebd8d379462f0dc95ba9246cbc6a1fece6e72d Mon Sep 17 00:00:00 2001 From: baldurk Date: Sat, 12 Sep 2020 23:15:17 +0100 Subject: [PATCH] Fix mistake enabling BDA capture replay if original BDA wasn't enabled --- renderdoc/driver/vulkan/wrappers/vk_device_funcs.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/renderdoc/driver/vulkan/wrappers/vk_device_funcs.cpp b/renderdoc/driver/vulkan/wrappers/vk_device_funcs.cpp index 7b291662e..dd3e27ad1 100644 --- a/renderdoc/driver/vulkan/wrappers/vk_device_funcs.cpp +++ b/renderdoc/driver/vulkan/wrappers/vk_device_funcs.cpp @@ -2918,8 +2918,9 @@ bool WrappedVulkan::Serialise_vkCreateDevice(SerialiserType &ser, VkPhysicalDevi if(existing) { + if(existing->bufferDeviceAddress) + existing->bufferDeviceAddressCaptureReplay = VK_TRUE; existing->bufferDeviceAddress = VK_TRUE; - existing->bufferDeviceAddressCaptureReplay = VK_TRUE; } else { @@ -2959,9 +2960,10 @@ bool WrappedVulkan::Serialise_vkCreateDevice(SerialiserType &ser, VkPhysicalDevi if(existing) { + if(existing->bufferDeviceAddress) + existing->bufferDeviceAddressCaptureReplay = VK_TRUE; // if so, make sure the feature is enabled existing->bufferDeviceAddress = VK_TRUE; - existing->bufferDeviceAddressCaptureReplay = VK_TRUE; } else { @@ -2997,9 +2999,11 @@ bool WrappedVulkan::Serialise_vkCreateDevice(SerialiserType &ser, VkPhysicalDevi if(existing) { + if(existing->bufferDeviceAddress) + existing->bufferDeviceAddressCaptureReplay = VK_TRUE; + // if so, make sure the feature is enabled existing->bufferDeviceAddress = VK_TRUE; - existing->bufferDeviceAddressCaptureReplay = VK_TRUE; } else {