From 5145478d19dadbd7356c730f7479e1b2889fdc91 Mon Sep 17 00:00:00 2001 From: baldurk Date: Thu, 6 Sep 2018 10:59:15 +0100 Subject: [PATCH] Remove unused config variable LastCaptureExe * In the .NET UI this was used to pre-fill the executable selection dialog, but it's unnecessary and hasn't been missed. --- qrenderdoc/Code/Interface/PersistantConfig.h | 6 ------ qrenderdoc/Windows/Dialogs/CaptureDialog.cpp | 4 ---- 2 files changed, 10 deletions(-) diff --git a/qrenderdoc/Code/Interface/PersistantConfig.h b/qrenderdoc/Code/Interface/PersistantConfig.h index ed9cee1a4..c51341aa1 100644 --- a/qrenderdoc/Code/Interface/PersistantConfig.h +++ b/qrenderdoc/Code/Interface/PersistantConfig.h @@ -274,8 +274,6 @@ DECLARE_REFLECTION_STRUCT(BugReport); \ CONFIG_SETTING_VAL(public, QString, rdcstr, LastCapturePath, "") \ \ - CONFIG_SETTING_VAL(public, QString, rdcstr, LastCaptureExe, "") \ - \ CONFIG_SETTING(public, QVariantList, rdcarray, RecentCaptureSettings) \ \ CONFIG_SETTING_VAL(public, QString, rdcstr, TemporaryCaptureDirectory, "") \ @@ -450,10 +448,6 @@ For more information about some of these settings that are user-facing see The path containing the last executable that was captured, which is useful as a default location for browsing. -.. data:: LastCaptureExe - - The path to the last executable that was captured, inside :data:`LastCapturePath`. - .. data:: RecentCaptureSettings A ``list`` of ``str`` with the recently opened capture settings files. diff --git a/qrenderdoc/Windows/Dialogs/CaptureDialog.cpp b/qrenderdoc/Windows/Dialogs/CaptureDialog.cpp index 8705d463e..8f8138370 100644 --- a/qrenderdoc/Windows/Dialogs/CaptureDialog.cpp +++ b/qrenderdoc/Windows/Dialogs/CaptureDialog.cpp @@ -568,7 +568,6 @@ bool CaptureDialog::checkAllowClose() void CaptureDialog::on_exePathBrowse_clicked() { QString initDir; - QString file; QFileInfo f(ui->exePath->text()); QDir dir = f.dir(); @@ -579,8 +578,6 @@ void CaptureDialog::on_exePathBrowse_clicked() else if(!m_Ctx.Config().LastCapturePath.isEmpty()) { initDir = m_Ctx.Config().LastCapturePath; - if(!m_Ctx.Config().LastCaptureExe.isEmpty()) - file = m_Ctx.Config().LastCaptureExe; } QString filename; @@ -927,7 +924,6 @@ void CaptureDialog::SetExecutableFilename(const rdcstr &filename) if(!m_Ctx.Replay().CurrentRemote()) { m_Ctx.Config().LastCapturePath = QFileInfo(fn).absolutePath(); - m_Ctx.Config().LastCaptureExe = QFileInfo(fn).completeBaseName(); } }