From 5183420f142eaf8650198b04de09bc89bb251f8c Mon Sep 17 00:00:00 2001 From: baldurk Date: Thu, 9 Jun 2016 13:11:10 -0700 Subject: [PATCH] Coverity: Fix potential NULL pointer dereference --- renderdoc/driver/gl/gl_replay.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/renderdoc/driver/gl/gl_replay.cpp b/renderdoc/driver/gl/gl_replay.cpp index 567235026..1c59a580e 100644 --- a/renderdoc/driver/gl/gl_replay.cpp +++ b/renderdoc/driver/gl/gl_replay.cpp @@ -2001,17 +2001,18 @@ void GLReplay::FillCBufferValue(WrappedOpenGL &gl, GLuint prog, bool bufferBacke for(uint32_t c = 0; c < majorsize; c++) { - if(datasize > 0) + if(bufdata != 0 && datasize > 0) memcpy((byte *)dest, bufdata, RDCMIN(rangelen, minorsize * sizeof(float))); datasize -= RDCMIN(datasize, (size_t)matStride); - bufdata += matStride; + if(bufdata != 0) + bufdata += matStride; dest += minorsize; } } else { - if(datasize > 0) + if(bufdata != 0 && datasize > 0) memcpy(&outVar.value.uv[0], bufdata, RDCMIN(rangelen, datasize)); } }