Split out some miscellaneous utility functions

* We also wrap up and cache the fetching of friendly names by serial number to avoid some adb traffic.
2026-07-11 18:17:16 +00:00 · 2018-01-26 16:30:16 +00:00
parent 1be3e8bfac
commit 5527c57e68
9 changed files with 151 additions and 103 deletions
@@ -0,0 +1,123 @@
+/******************************************************************************
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2018 Baldur Karlsson
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ ******************************************************************************/
+
+#include "android_utils.h"
+#include "core/core.h"
+#include "strings/string_utils.h"
+
+static std::map<std::string, std::string> friendlyNameCache;
+
+namespace Android
+{
+bool IsHostADB(const char *hostname)
+{
+  return !strncmp(hostname, "adb:", 4);
+}
+
+void ExtractDeviceIDAndIndex(const std::string &hostname, int &index, std::string &deviceID)
+{
+  if(!IsHostADB(hostname.c_str()))
+    return;
+
+  const char *c = hostname.c_str();
+  c += 4;
+
+  index = atoi(c);
+
+  c = strchr(c, ':');
+
+  if(!c)
+  {
+    index = 0;
+    return;
+  }
+
+  c++;
+
+  deviceID = c;
+}
+
+bool CheckRootAccess(const std::string &deviceID)
+{
+  RDCLOG("Checking for root access on %s", deviceID.c_str());
+
+  Process::ProcessResult result = {};
+
+  // Try switching adb to root and check a few indicators for success
+  // Nothing will fall over if we get a false positive here, it just enables
+  // additional methods of getting things set up.
+
+  result = adbExecCommand(deviceID, "root");
+
+  std::string whoami = trim(adbExecCommand(deviceID, "shell whoami").strStdout);
+  if(whoami == "root")
+    return true;
+
+  std::string checksu =
+      trim(adbExecCommand(deviceID, "shell test -e /system/xbin/su && echo found").strStdout);
+  if(checksu == "found")
+    return true;
+
+  return false;
+}
+
+bool SearchForAndroidLibrary(const std::string &deviceID, const std::string &location,
+                             const std::string &layerName, std::string &foundLayer)
+{
+  RDCLOG("Checking for layers in: %s", location.c_str());
+  foundLayer =
+      trim(adbExecCommand(deviceID, "shell find " + location + " -name " + layerName).strStdout);
+  if(!foundLayer.empty())
+  {
+    RDCLOG("Found RenderDoc layer in %s", location.c_str());
+    return true;
+  }
+  return false;
+}
+
+std::string GetFriendlyName(std::string deviceID)
+{
+  auto it = friendlyNameCache.find(deviceID);
+  if(it != friendlyNameCache.end())
+    return it->second;
+
+  std::string manuf =
+      trim(Android::adbExecCommand(deviceID, "shell getprop ro.product.manufacturer").strStdout);
+  std::string model =
+      trim(Android::adbExecCommand(deviceID, "shell getprop ro.product.model").strStdout);
+
+  std::string &combined = friendlyNameCache[deviceID];
+
+  if(manuf.empty() && model.empty())
+    combined = "";
+  else if(manuf.empty() && !model.empty())
+    combined = model;
+  else if(!manuf.empty() && model.empty())
+    combined = manuf + " device";
+  else if(!manuf.empty() && !model.empty())
+    combined = manuf + " " + model;
+
+  return combined;
+}
+};